From owner-svn-ports-head@FreeBSD.ORG  Sat Mar 21 15:05:43 2015
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 24D48552; Sat, 21 Mar 2015 15:05:43 +0000 (UTC)
Date: Sat, 21 Mar 2015 15:05:43 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Mathieu Arnold <mat@FreeBSD.org>
Subject: Re: svn commit: r381789 - in head/security/openssl: . files
Message-ID: <20150321150543.GC55163@FreeBSD.org>
References: <201503211053.t2LArEMw041053@svn.freebsd.org>
 <C91A13C9C4702AD75CF332CB@atuin.in.mat.cc>
 <20150321144244.GA55163@FreeBSD.org>
 <1AEB8BFF81EB37117B9DC39E@atuin.in.mat.cc>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1AEB8BFF81EB37117B9DC39E@atuin.in.mat.cc>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: Dirk Meyer <dinoex@FreeBSD.org>, svn-ports-head@freebsd.org,
 svn-ports-all@freebsd.org, ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 21 Mar 2015 15:05:43 -0000

On Sat, Mar 21, 2015 at 03:50:16PM +0100, Mathieu Arnold wrote:
> +--On 21 mars 2015 14:42:44 +0000 Alexey Dokuchaev <danfe@FreeBSD.org>
> wrote:
> | On Sat, Mar 21, 2015 at 02:15:52PM +0100, Mathieu Arnold wrote:
> |> +--On 21 mars 2015 10:53:14 +0000 Dirk Meyer <dinoex@FreeBSD.org> wrote:
> |> |  PORTNAME=	openssl
> |> | -PORTVERSION=	1.0.1
> |> | -DISTVERSIONSUFFIX=	m
> |> | -PORTREVISION=	19
> |> | +PORTVERSION=	1.0.2
> |> | +DISTVERSIONSUFFIX=	a
> |> | +PORTREVISION=	0
> |> 
> |> Would you consider setting PORTVERSION=1.0.2a and dropping
> |> DISTVERSIONSUFFIX ? It is mostly confusing to not have the openssl
> |> package have the real version all the time.
> | 
> | Except that is should probably be DISTVERSION, not PORTVERSION in this
> | case, to make it more "monotonic versions" friendly.
> 
> I'm not sure exactly what it would achieve, save, maybe not put the right
> version number where it should be.
> 
> $ pkg version -t 1.0.2 1.0.2a
> <
> $ pkg version -t 1.0.2a 1.0.2b
> <
> $ pkg version -t 1.0.2b 1.0.2c
> <
> $ pkg version -t 1.0.2d 1.0.2c

Hmm, perhaps in this case (OpenSSL) PORTVERSION in indeed correct choice,
sorry for the noise.

./danfe