From owner-cvs-src@FreeBSD.ORG Tue Nov 15 12:23:05 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DAA8916A41F; Tue, 15 Nov 2005 12:23:05 +0000 (GMT) (envelope-from ariff@FreeBSD.org) Received: from tomoyo.MyBSD.org.my (tomoyo.mybsd.org.my [202.157.186.227]) by mx1.FreeBSD.org (Postfix) with ESMTP id 14FBA43D46; Tue, 15 Nov 2005 12:23:05 +0000 (GMT) (envelope-from ariff@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) by tomoyo.MyBSD.org.my (Postfix) with ESMTP id A93D96CC24; Tue, 15 Nov 2005 20:25:50 +0800 (MYT) Received: from tomoyo.MyBSD.org.my ([127.0.0.1]) by localhost (TOMOYO.MYBSD.ORG.MY [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 61551-10; Tue, 15 Nov 2005 20:25:49 +0800 (MYT) Received: from kasumi.MyBSD.org.my (kasumi.MyBSD.org.my [IPv6:2001:328:2002:aa2::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tomoyo.MyBSD.org.my (Postfix) with ESMTP id C5A286CC23; Tue, 15 Nov 2005 20:25:48 +0800 (MYT) Date: Tue, 15 Nov 2005 20:23:06 +0800 From: Ariff Abdullah To: Robert Watson Message-Id: <20051115202306.4cf2dcf2.ariff@FreeBSD.org> In-Reply-To: <20051115095801.M61850@fledge.watson.org> References: <200511150419.jAF4JRUp080869@repoman.freebsd.org> <20051115105128.a5dd001i0ckock0s@netchild.homeip.net> <20051115095801.M61850@fledge.watson.org> Organization: FreeBSD X-Mailer: /usr/local/lib/ruby/1.8/net/smtp.rb Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="PGP-SHA1"; boundary="Signature=_Tue__15_Nov_2005_20_23_06_+0800_hn8LEwlIaFdsClwU" X-Virus-Scanned: by Amavisd AntiVirus & AntiSpam Scanner running on FreeBSD mailserver at TOMOYO.MYBSD.ORG.MY Cc: src-committers@FreeBSD.org, kan@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org, arr@FreeBSD.org, Alexander@Leidinger.net Subject: Re: cvs commit: src/sys/dev/sound/pcm channel.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Nov 2005 12:23:06 -0000 --Signature=_Tue__15_Nov_2005_20_23_06_+0800_hn8LEwlIaFdsClwU Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, 15 Nov 2005 09:58:52 +0000 (GMT) Robert Watson wrote: >=20 > On Tue, 15 Nov 2005, Alexander Leidinger wrote: >=20 > >> Modified files: > >> sys/dev/sound/pcm channel.c > >> Log: > >> Unbreak kernel builds. > >>=20 > >> Submitted by: arr > > > > Hos does the change from "min & (min-1) =3D=3D 0" to "(min & (min-1)) > > =3D=3D 0" fix the building of a kernel (what was the error message > > from gcc)? >=20 > Probably a combination of -Wall and -Werror, which generally > generates a warning along the following lines: >=20 > warning: suggest parentheses around comparison in operand of & >=20 That means, warnings caused by excessive inlining while compiling maestro.c should also break the build if WARNS=3D1, right? Has anybody encounter and getting annoyed by this? -- Ariff Abdullah FreeBSD --Signature=_Tue__15_Nov_2005_20_23_06_+0800_hn8LEwlIaFdsClwU Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDedMtlr+deMUwTNoRAr9sAKDDWwh/yvMxOXCDJm600L8YdoQCVACdGowq xPpZCMWtf7uBXc85/HQLsUY= =KMCB -----END PGP SIGNATURE----- --Signature=_Tue__15_Nov_2005_20_23_06_+0800_hn8LEwlIaFdsClwU--