From owner-freebsd-ports@FreeBSD.ORG Wed Apr 14 06:47:04 2010 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A33C21065680 for ; Wed, 14 Apr 2010 06:47:04 +0000 (UTC) (envelope-from john.c.prather@gmail.com) Received: from mail-pz0-f201.google.com (mail-pz0-f201.google.com [209.85.222.201]) by mx1.freebsd.org (Postfix) with ESMTP id 791FD8FC1B for ; Wed, 14 Apr 2010 06:47:04 +0000 (UTC) Received: by pzk39 with SMTP id 39so761367pzk.7 for ; Tue, 13 Apr 2010 23:47:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:received:message-id :subject:from:to:content-type:content-transfer-encoding; bh=ij7bvSAZD9g5PvIf2MB60eesVu/JhU7DpHrEaScv9pM=; b=tpc6VHv2g65nF6rdvS/jnWPREaCr25sntkn84OjMKtXQtzPYugOEH5NTxhwhQ2WmCo FC3ujFExMpP04WemwlZZ5kViTZ+GshD4RRrmZywqZuKm9Hvu8PaQMg4B4BI/D6BMmrzD nIUYBDk4kPYRyu9xFljZBH6VKNMq1ZeMa8x8s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type :content-transfer-encoding; b=wXiCdfrNaUGduueHJlvUue37+/gwDGi1H6muFdJJ73Y2t7vL0ZXRY6bNK3QTePO426 ywoCsZcfc9YsDnwvVR94RRmhxNEC1DYEYVaNJgdctpxxK0i5racuVMl021gwMd1vVLbR NOdhp4iRJCZgld9hhGXYPsSMKz/blhrmBh7x4= MIME-Version: 1.0 Received: by 10.140.135.13 with HTTP; Tue, 13 Apr 2010 23:19:04 -0700 (PDT) Date: Tue, 13 Apr 2010 23:19:04 -0700 Received: by 10.141.187.20 with SMTP id o20mr6518673rvp.13.1271225944717; Tue, 13 Apr 2010 23:19:04 -0700 (PDT) Message-ID: From: John Prather To: freebsd-ports@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: State of gmime (mail/gmime24) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Apr 2010 06:47:04 -0000 Hello, I've been maintaining a port which provides a plugin for Pidgin (net-im/pidgin-sipe), which has recently introduced the option to build a telepathy plugin in addition to or instead of the purple plugin. Building the telepathy plugin causes gnu configure to require gmime 2.4 >=3D 2.4.16 (mail/gmime24 is 2.4.10 currently) or gmime 2.6 >=3D 2.5.2 (seems to be no 2.6 port yet). I've found that I can easily patch one of the bug fixes I found (https://bugzilla.gnome.org/show_bug.cgi?id=3D613653#c8) that the sipe developers deemed necessary into the 2.4.10 port, however I'm wary of going crazy with freebsd patches for 2.4.10 if we are going to have 2.4.16 out in the near future, or 2.6 >=3D 2.5.2 made available. =A0Also, there may be other important bug fixes, though the others which i found that the sipe developers were concerned with were all related to building on Windows. Do we feel that patching 2.4.10 with relatively simple patches would be a decent approach, or should we wait for either 2.4.16 release and the corresponding port update or 2.6 to be added into ports? =A0I partly feel we should wait for the correct versions to be made available, but it seems silly to wait weeks or months or more and deal with someone having to port a whole new release over such a simple fix. Here is what the patches look like which seem to apply nicely to 2.4.10 in mail/gmime24: (i'm sure the email turned tabs to spaces, but you can see the gist of it. I can post the unmangled patch files somewhere if they are desired) [root@bsdlaptop /usr/ports/mail/gmime24]# cat files/patch-gmime_gmime.c *** gmime/gmime.c.orig =A0Tue Apr 13 22:45:25 2010 --- gmime/gmime.c =A0 =A0 =A0 Tue Apr 13 22:46:09 2010 *************** *** 141,147 **** =A0{ =A0 =A0 =A0 =A0if (--initialized) =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return; ! =A0 =A0 =A0 =A0g_mime_charset_map_shutdown (); =A0 =A0 =A0 =A0g_mime_iconv_shutdown (); =A0} --- 141,148 ---- =A0{ =A0 =A0 =A0 =A0if (--initialized) =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return; ! ! =A0 =A0 =A0 g_mime_object_shutdown(); =A0 =A0 =A0 =A0g_mime_charset_map_shutdown (); =A0 =A0 =A0 =A0g_mime_iconv_shutdown (); =A0} [root@bsdlaptop /usr/ports/mail/gmime24]# cat files/patch-gmime_gmime-object.c *** gmime/gmime-object.c.orig =A0 Tue Apr 13 22:46:38 2010 --- gmime/gmime-object.c =A0 =A0 =A0 =A0Tue Apr 13 22:48:48 2010 *************** *** 1061,1068 **** =A0 =A0 =A0 =A0g_free (bucket); =A0} ! static void ! type_registry_shutdown (void) =A0{ =A0 =A0 =A0 =A0g_hash_table_foreach (type_hash, type_bucket_foreach, NULL); =A0 =A0 =A0 =A0g_hash_table_destroy (type_hash); --- 1061,1068 ---- =A0 =A0 =A0 =A0g_free (bucket); =A0} ! void ! g_mime_object_shutdown (void) =A0{ =A0 =A0 =A0 =A0g_hash_table_foreach (type_hash, type_bucket_foreach, NULL); =A0 =A0 =A0 =A0g_hash_table_destroy (type_hash); *************** *** 1075,1080 **** =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return; =A0 =A0 =A0 =A0type_hash =3D g_hash_table_new (g_mime_strcase_hash, g_mime_= strcase_equal); - - =A0 =A0 =A0 g_atexit (type_registry_shutdown); =A0} --- 1075,1078 ---- [root@bsdlaptop /usr/ports/mail/gmime24]# cat files/patch-gmime_gmime-objec= t.h *** gmime/gmime-object.h.orig =A0 Tue Apr 13 22:49:01 2010 --- gmime/gmime-object.h =A0 =A0 =A0 =A0Tue Apr 13 22:49:51 2010 *************** *** 94,99 **** --- 94,100 ---- =A0GType g_mime_object_get_type (void); =A0void g_mime_object_register_type (const char *type, const char *subtype, GType object_type); + void g_mime_object_shutdown (void); =A0GMimeObject *g_mime_object_new (GMimeContentType *content_type); =A0GMimeObject *g_mime_object_new_type (const char *type, const char *subty= pe); -- John Prather