From nobody Fri May 29 15:27:02 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gRnK85wXkz6fhkF for ; Fri, 29 May 2026 15:27:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gRnK80kmTz47j0 for ; Fri, 29 May 2026 15:27:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780068428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=l5oP6HCrPAeEIlc5gngiEf3eutbBTwcMo1PqZK8QC5Q=; b=WiuX05mUmKL+ea8wHb1HjoF+ua69yo0Hc/EcOyLzOHRL7pnFO9bhTeEfwYRpxE1ofrsVRK mPXu4qAGSmN7w67BDjCzF3j0yG4hWr7a/r86lTfaIRY5Zyzw0hRvGluX0sqFAYMzPJ2VAK fiKS2LVnBfqsCB6DEPg5DpjJ50sQPrNjbXecv+fm9bNDlEfiTNMhPjUNqmmV5eArwLEHYk cX1RRF+Jg4K19FTLFsh7QuW2yWW1b3CcBA9SwtUp08QivgOfcN+e7tLZ3TULgRvnYHn7AK b5h/kzs8+qoNz4EpZQGG4DTcCxa/kI6N5aX4UUWsFNLVj+X//ttMsN3XU55B2g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1780068428; a=rsa-sha256; cv=none; b=e2eCnDMOayefBrxP8qxQtQ1YRlzoXECkwTgtonybiqiAW41eFLmuUZ9v6Xtjq0gXs2f1Gl kBJ51MN/97FMTtUxeOUXpA02ylaI3kD4EtdPObxLRf/aXSRS19kAY9S5IZGpv6u8H8pboZ ARS+zHbRTXhp3MBObw+F58Low5j7slaJIFvlAMxQ/7pk7ToFO7XIXlHYQdLs3Izl6e5OI0 aOJaYkstepeZkvaNxv5vn2+mL/a7WZsEcxg1Ey9LdXEpOh76OTPEbbnyw8SMrGRgYLquJZ kf2I88d51ZF+EPAlRWXJSh8GO7kQs2+IVcUIu9Rtudb1HElmVraNo6CiRHp1aw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1780068428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=l5oP6HCrPAeEIlc5gngiEf3eutbBTwcMo1PqZK8QC5Q=; b=bRz4C/CL9/rk5jWRVzArqiP3t070gowmrJ700osM0ft0vFjOFv86UcbPgpJOQfvvU2SmmZ 1LSSdU9DzOt3xJPW43sH2Iqn18pra6gbn0Kjk8zs1bonc7Fk5i8TX2kr9H/LRYrMRwtc7S 9POdngBg7LpVbpy1HTpoaQIU2rzWmBCmZ8/rMw5GHKJADoNQSxR0LGAq2mhQheCwmaGtMV h7rhJMB8QRmWMxI9NjJCq2AfIznMUg0F5yTd4vR5myJQqVwh5CWvLK9nLFokQt2dDpPqBA LmpZu3rURzl+Eai9b8anYZR0qy8/Eh4BSsTtTkfsbTd0h0gNpyhAtaRwXiyoRQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gRnK76v72zfMB for ; Fri, 29 May 2026 15:27:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 30e45 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 29 May 2026 15:27:02 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Gisle Nes From: ShengYi Hung Subject: git: abd66d6418b6 - stable/14 - pci: use uint32_t for eecp List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: aokblast X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: abd66d6418b60e17bcf3a822a1800d0a5dc2bcd4 Auto-Submitted: auto-generated Date: Fri, 29 May 2026 15:27:02 +0000 Message-Id: <6a19b046.30e45.78f4d929@gitrepo.freebsd.org> The branch stable/14 has been updated by aokblast: URL: https://cgit.FreeBSD.org/src/commit/?id=abd66d6418b60e17bcf3a822a1800d0a5dc2bcd4 commit abd66d6418b60e17bcf3a822a1800d0a5dc2bcd4 Author: Gisle Nes AuthorDate: 2026-04-07 16:48:15 +0000 Commit: ShengYi Hung CommitDate: 2026-05-29 15:25:00 +0000 pci: use uint32_t for eecp eecp holds the extended capability offset. If that offset is larger than 0xff, storing it in uint8_t truncates it, which can make the early EHCI/XHCI capability walk read the wrong location and loop during boot. Seen on AMD device 1022:151e, where HCCPARAMS1 = 0x0118ffc5 and the first xHCI extended capability offset is 0x460. Widen eecp to uint32_t in xhci_early_takeover(), matching xhci_pci_take_controller(). Signed-off-by: Gisle Nes Reviewed by: zlei, aokblast MFC after: 3 days Pull Request: https://github.com/freebsd/freebsd-src/pull/2127 Closes: https://github.com/freebsd/freebsd-src/pull/2127 (cherry picked from commit 555ffd9022de0c497881bafc413e3e1d05af10d4) --- sys/dev/pci/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/pci/pci.c b/sys/dev/pci/pci.c index 0a1ea29180dd..58fdbe1703f1 100644 --- a/sys/dev/pci/pci.c +++ b/sys/dev/pci/pci.c @@ -3727,7 +3727,7 @@ xhci_early_takeover(device_t self) struct resource *res; uint32_t cparams; uint32_t eec; - uint8_t eecp; + uint32_t eecp; uint8_t bios_sem; uint8_t offs; int rid;