From owner-freebsd-net@FreeBSD.ORG Thu Apr 3 16:00:19 2014 Return-Path: Delivered-To: net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 090EBEB4 for ; Thu, 3 Apr 2014 16:00:19 +0000 (UTC) Received: from mail-wi0-x22b.google.com (mail-wi0-x22b.google.com [IPv6:2a00:1450:400c:c05::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 98144DDD for ; Thu, 3 Apr 2014 16:00:18 +0000 (UTC) Received: by mail-wi0-f171.google.com with SMTP id q5so9507781wiv.10 for ; Thu, 03 Apr 2014 09:00:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=JzpuD/pM8S9OicTXakalhNGGrAoWcmq39ZhbwmCyG24=; b=ni3Tn93zdF/58w+fFOR1lD+1aJhgeHnMNy7sjVmuXke5zE+AAvizUkD6QXxlEs76j/ F7D6hRhurJZ6ylHC5sOEObylEKjekJdMmPPuXJ8RHLrW9hRw1sv0nmt+otmnoH3dJd9/ 6VS2YMZYbNpL6kDv1TtRzlLfAC2Sf6RqKd9ZOjm7ZqN+LRBSC2557a+38hkTaF5hwrZb 0lyC9nW+/yR5z8c4BSPiSeD0xzSzMac2JFrLXDUeUHlyn8ozH7noKpbgwBiDHmLoB4kP gUn76lJ3TEJ/gSbjwpVGq/vnVBneGC+AqUxk/Sva4jRxOCPF8MZm5/CNRBYQGl27BqcM 3UFg== MIME-Version: 1.0 X-Received: by 10.194.119.168 with SMTP id kv8mr11674670wjb.41.1396540816951; Thu, 03 Apr 2014 09:00:16 -0700 (PDT) Received: by 10.14.211.134 with HTTP; Thu, 3 Apr 2014 09:00:16 -0700 (PDT) In-Reply-To: <533D459F.8000403@sfc.wide.ad.jp> References: <5338FF05.1020302@sfc.wide.ad.jp> <533D459F.8000403@sfc.wide.ad.jp> Date: Thu, 3 Apr 2014 09:00:16 -0700 Message-ID: Subject: Re: DCTCP implementation From: hiren panchasara To: Midori Kato Content-Type: text/plain; charset=UTF-8 Cc: "Eggert, Lars" , "freebsd-net@freebsd.org" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Apr 2014 16:00:19 -0000 On Thu, Apr 3, 2014 at 4:27 AM, Midori Kato wrote: > Hi Hiren, > > Yes, I intentionally replace the location of DELAY_ACK() macro. > A DCTCP receiver sends an immediate ACK when incoming packets sets CE and > non-CE bit by turns. To implement this processing, I prepare the > cc_ecnpkt_handler() function. This function calls the DEKAY_ACK() macro to > check if this packet is in delayed ack or not. This is why I replace the > macro position. That is fine but macro definition is also changed. This is how it looks on -HEAD right now: #define DELAY_ACK(tp, tlen) \ ((!tcp_timer_active(tp, TT_DELACK) && \ (tp->t_flags & TF_RXWIN0SENT) == 0) && \ (tlen <= tp->t_maxopd) && \ (V_tcp_delack_enabled || (tp->t_flags & TF_NEEDSYN))) We need to pass this new argument "tlen" when calling DELAY_ACK() from cc_ecnpkt_handler() function. We can probably pass that to cc_encpkg_handler() while calling it from tcp_do_segment(). I'll make that change and see how it goes. cheers, Hiren > > Regards, > -- Midori > > > (4/3/14, 10:24 AM), hiren panchasara wrote: >> >> On Sun, Mar 30, 2014 at 10:37 PM, Midori Kato >> wrote: >>> >>> Hi FreeBSD developpers, >>> >>> I'm Midori Kato. I'm working on the DCTCP implementation in the FreeBSD >>> with >>> Lars Eggert. I mail you because I would like to ask you a code review and >>> testing. The attached patch is not good enough to test our code. Please >>> give >>> me your message. I will send an ECN marking implmenetation in dummynet >>> and >>> test scripts personally to you. >> >> Midori, >> >> First thing I noticed in your dctcp.patch is that you are dropping >> r256920 which adds a new argument tlen to DELAY_ACK() macro. I also >> see you removed and re-added that macro definition without any changes >> to it. >> >> Is that intentional? If not, can you please fix that and resend the patch? >> >> It is usually a good idea to work on -HEAD for such things so >> patching/committing is easier. >> >> cheers, >> Hiren >> _______________________________________________ >> freebsd-net@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-net >> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > >