From owner-svn-src-head@freebsd.org Fri Aug 17 15:25:35 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6FD0010722DC; Fri, 17 Aug 2018 15:25:35 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D0FB183480; Fri, 17 Aug 2018 15:25:34 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-lj1-x241.google.com with SMTP id q127-v6so6660733ljq.11; Fri, 17 Aug 2018 08:25:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=G4LW74zrJE7mlyLluMeRQpprUwyf2BIFJY8Z8EOB2PY=; b=rExdc22awBqLph+4WE2aq5bGgW49W1JwhPzmPxtAf8ILldVUB04nMvJdlQvhnjyw7+ Qna/oUbzFYXL2ybW7pqzl1gJg0+AIbxpaYRAr9EhbSAJe+r/NXN27wJOAj3xN3WpkO0D 13wX+rvfnIOY+o7lBj1Gk4DyYn9ARRgm6uHo7PWE2nWYQJzD8bX8edOYKYVghjFUN/o5 bUH7nA/6XitpkTKDcrJ/CaU1NWAmeb26+bGaMtMHGe+kIWVP0LGf1RPnWH5putEqU0W3 osjyDCfpX1gQe4+5a8LYGb0B5iADQ+k3DVHS0184TBblPEODHryhBOYr3daUclfmp1gA R6vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=G4LW74zrJE7mlyLluMeRQpprUwyf2BIFJY8Z8EOB2PY=; b=HJBipU7FRNXy4sJWZyj7i2mItF64gxXtiEEKQSg977wR/FQ0pdYlhahJ+F7Jh0AJX3 XwKJQH1JbE2Xp7cs0Wr9spb3828JJQhIIJyc9IsG7Bv/dE3VtYyvKL/BMNYpr8JzntvU YKHatvNVWtQNUQ6Bd3EcugUeFCwL7/JQkRqnwykwCTbpJi0zxITVrDwgaIsswimVH+Ua OnwJbjm4ru9wILXUhvWY6lKbS8Xx03t3+2fqBIv5bprAp5jC+j49kfAAJQxdOPgR4eyZ r7f7HnPuYM0jOJru4+THRLhwnpBxwF2URcpZEX6e1Sj7z/4pJV2hotO1YtleKn0TJBej qfZA== X-Gm-Message-State: AOUpUlGrq7OV4F4Cu1Zz09S0TMM8o2BjO7ug/bKM4grekrzZS0KQaj5j LlktQvJtzfHb3s5UcWdB/xQ6WLF2TuM4eTFwj+7t/A== X-Google-Smtp-Source: AA+uWPzkxBr9XzGA4iquz677SRNnRYMDSf1JhF6jhAJMpO5iCVfVYC0tPOfnDWZxZDmZF7gJn0N17t+elSToNIbj6Do= X-Received: by 2002:a2e:87da:: with SMTP id v26-v6mr23974673ljj.69.1534519533329; Fri, 17 Aug 2018 08:25:33 -0700 (PDT) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 2002:ab3:7851:0:0:0:0:0 with HTTP; Fri, 17 Aug 2018 08:25:32 -0700 (PDT) In-Reply-To: References: <201808140754.w7E7sEFs018313@repo.freebsd.org> From: Alan Somers Date: Fri, 17 Aug 2018 09:25:32 -0600 X-Google-Sender-Auth: jFT0QTymParWI8yVFp_HGqIyfng Message-ID: Subject: Re: svn commit: r337736 - in head/sys: netinet netinet6 To: "Andrey V. Elsukov" Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Aug 2018 15:25:35 -0000 On Fri, Aug 17, 2018 at 7:31 AM, Andrey V. Elsukov wrote: > On 16.08.2018 21:34, Alan Somers wrote: > > On Tue, Aug 14, 2018 at 1:54 AM, Andrey V. Elsukov > > wrote: > > > > Author: ae > > Date: Tue Aug 14 07:54:14 2018 > > New Revision: 337736 > > URL: https://svnweb.freebsd.org/changeset/base/337736 > > > > > > Log: > > Restore ability to send ICMP and ICMPv6 redirects. > > > > It was lost when tryforward appeared. Now ip[6]_tryforward will be > > enabled > > only when sending redirects for corresponding IP version is > > disabled via > > sysctl. Otherwise will be used default forwarding function. > > > > PR: 221137 > > > > This change broke the sys/netipsec/tunnel tests. I don't know if it's a > > limitation of the tests, or a genuine kernel bug, but I bisected the > > regression down to this change. Can you please fix it? > > > > https://ci.freebsd.org/job/FreeBSD-head-amd64-test/8630/ > testReport/sys.netipsec.tunnel/empty/v4/ > > I think it is because IPv4 tests use broadcast addresses in some places. > The attached patch fixes the test for me. > > -- > WBR, Andrey V. Elsukov > Hm, it certainly is weird to use broadcast addresses in this context. But why did that work before your commit and not after?