From owner-svn-src-all@freebsd.org Fri Apr 22 06:40:31 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 32EB3B18722; Fri, 22 Apr 2016 06:40:31 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x235.google.com (mail-pf0-x235.google.com [IPv6:2607:f8b0:400e:c00::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0554212DA; Fri, 22 Apr 2016 06:40:31 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x235.google.com with SMTP id 184so38491928pff.0; Thu, 21 Apr 2016 23:40:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=H0p9FTixt0K7K7HwH9lWNlRPS19YmZNjEl6DyfjtSpE=; b=pB9/Cdvf+skOf6r2vfgjlR/UYd+sOnMPRhcJBMq81VzjAdawpyjNFNetZk/VkqHaGC m9ZaXNV5izePFonhBUlaEvYooGEnkri4v+UVqGKI+A+JfPPNMb2jc9Ogcb7IRU3qFNhZ SF/Zdl16IMYYfDbbw5AeE6wMAHUZDaWO4lWx5PY4fPp5REird1VtGCf4sHLJmQBRmpUx ZIR0oHdezgtam0RQY6dLuvQxTilRVFkemcsilqhMA6How6nvsUQ1/KB5MfERtArJEmjj TIVeZtqA5HsKrFTzS1xlFOTRnAFZ+1uD7sU2D4vx+N2zpH4P2siaNO1f2mTNuEBJ9wHq jUcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=H0p9FTixt0K7K7HwH9lWNlRPS19YmZNjEl6DyfjtSpE=; b=DPNnuv/k5Tq9pveB6ZXNuLlBULPwqFhks9zAtoQfGOHOpQ7TQkTdwNzfvtMJXFLuyY 7un6CCvN7u7b8Vr6j3FATwIWX1T3wEWL6Mek6e04VQTSjtt3SyjIMukWgIN0gAHptPyU YsHPWVEOgoz6l9GfsEHxqcJuXa0H9sbs2HxQ0JNEl1UZdA5BjCK6sfr0qPul0RSK9FZa XttPb9ltFHdxGAzD7VXO7sSDmkJPhq5s8gOmFT9SCPAsTxvCo6Gkqfe9BkRAPomvnGoV wIXIF+hWU7r/biPG2DrCGcre6nd2BaLg5ZpklvF2gvLV6v2f1zbv0KT5GATSVQBp4ccg EJvQ== X-Gm-Message-State: AOPr4FWTQlmysnfq9VBUdqso25yB1bcLRFdr4FLasgAU7jie+hE56OE9EDDs1sZ4zFdzPQ== X-Received: by 10.98.36.195 with SMTP id k64mr26203654pfk.88.1461307230468; Thu, 21 Apr 2016 23:40:30 -0700 (PDT) Received: from [192.168.20.7] (c-73-97-222-46.hsd1.wa.comcast.net. [73.97.222.46]) by smtp.gmail.com with ESMTPSA id yp9sm6658685pab.42.2016.04.21.23.40.29 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 21 Apr 2016 23:40:29 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: svn commit: r298459 - head/sys/ofed/drivers/infiniband/core From: "Ngie Cooper (yaneurabeya)" In-Reply-To: <201604220639.u3M6d8vF010061@repo.freebsd.org> Date: Thu, 21 Apr 2016 23:40:28 -0700 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201604220639.u3M6d8vF010061@repo.freebsd.org> To: Hans Petter Selasky X-Mailer: Apple Mail (2.2104) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Apr 2016 06:40:31 -0000 > On Apr 21, 2016, at 23:39, Hans Petter Selasky = wrote: >=20 > Author: hselasky > Date: Fri Apr 22 06:39:07 2016 > New Revision: 298459 > URL: https://svnweb.freebsd.org/changeset/base/298459 >=20 > Log: > Add KASSERT() and set error code in dead code case to help static = code > analysis tools. >=20 > Suggested by: ngie@ > Sponsored by: Mellanox Technologies > MFC after: 1 week >=20 > Modified: > head/sys/ofed/drivers/infiniband/core/addr.c >=20 > Modified: head/sys/ofed/drivers/infiniband/core/addr.c > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/sys/ofed/drivers/infiniband/core/addr.c Fri Apr 22 = 06:33:06 2016 (r298458) > +++ head/sys/ofed/drivers/infiniband/core/addr.c Fri Apr 22 = 06:39:07 2016 (r298459) > @@ -404,6 +404,8 @@ mcast: > break; > #endif > default: > + KASSERT(0, ("rdma_addr_resolve: Unreachable")); > + error =3D EINVAL; > break; > } > RTFREE(rte); Thanks :)!=