Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 26 Mar 2015 21:18:57 +0100
From:      John Marino <freebsd.contact@marino.st>
To:        Bryan Drewery <bdrewery@FreeBSD.org>, John Marino <marino@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org,  svn-ports-head@freebsd.org
Subject:   Re: svn commit: r382339 - in head/x11-toolkits/swt: . files
Message-ID:  <551469B1.7090906@marino.st>
In-Reply-To: <551468CA.1080200@FreeBSD.org>
References:  <201503261937.t2QJbgfH048303@svn.freebsd.org> <551467E5.7050505@FreeBSD.org> <551468CA.1080200@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 3/26/2015 21:15, Bryan Drewery wrote:
> On 3/26/2015 3:11 PM, Bryan Drewery wrote:
>> On 3/26/2015 2:37 PM, John Marino wrote:
>>> Author: marino
>>> Date: Thu Mar 26 19:37:41 2015
>>> New Revision: 382339
>>> URL: https://svnweb.freebsd.org/changeset/ports/382339
>>> QAT: https://qat.redports.org/buildarchive/r382339/
>>>
>>> Log:
>>>   x11-toolkits/swt: Add DragonFly support
>>>   
>>>   Bring in fix from dports (port is not maintained)
>>>
>>> Modified:
>>>   head/x11-toolkits/swt/Makefile
>>>   head/x11-toolkits/swt/files/patch-build.sh
>>>
>>> Modified: head/x11-toolkits/swt/Makefile
>>> ==============================================================================
>>> --- head/x11-toolkits/swt/Makefile	Thu Mar 26 19:33:35 2015	(r382338)
>>> +++ head/x11-toolkits/swt/Makefile	Thu Mar 26 19:37:41 2015	(r382339)
>>> @@ -83,6 +83,10 @@ post-extract:
>>>  	@(cd ${WRKSRC} && ${UNZIP_CMD} -qo "*.zip")
>>>  	@${RM} -f ${WRKSRC}/*.o ${WRKSRC}/*.so ${WRKSRC}/*.jar
>>>  
>>> +post-patch:
>>> +	${SED} -e 's|freebsd|dragonfly|g' ${WRKSRC}/make_freebsd.mak \
>>> +		${WRKSRC}/make_dragonfly.mak
>>> +
>>
>> This being unconditional seems wrong.
>>
> 
> This is what I was talking about on #bsdports earlier. This is
> overly-specific. You could fix this so that both FreeBSD and DragonFly
> and WhateverOS works all the same. Replace freebsd with OPSYS:tl in
> make_freebsd.mak and FreeBSD with OPSYS in build.sh; This is not enough
> but it's in the direction. Considering that make_freebsd.mak and
> make_dragonfly.mak are the same they should be more generic for OPSYS.
> 

There's no point in making it generic because the configure script also
needs to be patched to use it.  Plus it may not work on any OS, I've not
tested it on any other OS.

This port is unmaintained.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?551469B1.7090906>