Date: Fri, 8 Jan 2021 14:21:21 -0800 From: John Baldwin <jhb@FreeBSD.org> To: Kyle Evans <kevans@freebsd.org>, Baptiste Daroussin <bapt@freebsd.org> Cc: Vladimir Kondratyev <vladimir@kondratyev.su>, Ravi Pokala <rpokala@freebsd.org>, Jessica Clarke <jrtc27@freebsd.org>, Vladimir Kondratyev <wulf@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@freebsd.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@freebsd.org> Subject: Re: 92cf602e3809 - main - Copy strcasestr.c from libc to libkern. Message-ID: <4628ea93-876c-be1c-1012-bc4353e0b31d@FreeBSD.org> In-Reply-To: <CACNAnaGo9zYvnTofuPyQYKqCyN4paYqbn5FnizyPHZQ=X-OXjQ@mail.gmail.com> References: <202101072320.107NKpMS063374@gitrepo.freebsd.org> <F0A2E7AD-499B-4CA5-AF6B-1C7F9F5B49BC@freebsd.org> <7a7fa0fb-51c2-1b14-6d37-2c400f69d7dd@kondratyev.su> <3EA011C9-2EEC-4693-B36D-69E74DF8473C@panasas.com> <a527f34b-2fbe-7729-e029-a820d0545910@kondratyev.su> <20210108092638.x2kkvpeftey2wk62@ivaldir.net> <CACNAnaGo9zYvnTofuPyQYKqCyN4paYqbn5FnizyPHZQ=X-OXjQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 1/8/21 5:46 AM, Kyle Evans wrote:
> On Fri, Jan 8, 2021 at 3:27 AM Baptiste Daroussin <bapt@freebsd.org> wrote:
>>
>> On Fri, Jan 08, 2021 at 02:49:31AM +0300, Vladimir Kondratyev wrote:
>>> On 08.01.2021 02:41, Ravi Pokala wrote:
>>>> -----Original Message-----
>>>> From: <owner-src-committers@freebsd.org> on behalf of Vladimir Kondratyev <vladimir@kondratyev.su>
>>>> Date: 2021-01-07, Thursday at 15:33
>>>> To: Jessica Clarke <jrtc27@freebsd.org>, Vladimir Kondratyev <wulf@FreeBSD.org>
>>>> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org>
>>>> Subject: Re: git: 92cf602e3809 - main - Copy strcasestr.c from libc to libkern.
>>>>
>>>> On 08.01.2021 02:27, Jessica Clarke wrote:
>>>> > On 7 Jan 2021, at 23:20, Vladimir Kondratyev <wulf@FreeBSD.org> wrote:
>>>> >> +#include <ctype.h>
>>>> >> +#include <string.h>
>>>> >> +#include "xlocale_private.h"
>>>> >> +
>>>> >> +/*
>>>> >> + * Find the first occurrence of find in s, ignore case.
>>>> >> + */
>>>> >> +char *
>>>> >> +strcasestr_l(const char *s, const char *find, locale_t locale)
>>>> >
>>>> > Locales in the kernel? This feels wrong.
>>>> >
>>>> > Jess
>>>> >
>>>>
>>>> strcasestr.c was copied from userland unmodified just to allow
>>>> "git log --follow" to work. Next commit removed locale support from this
>>>> file and connected it to build.
>>>>
>>>> Unfortunately, about two-dozen commit messages from you arrived at the same time, and some were out of order; without incrementing change numbers in the subject line, figuring out the actual ordering is non-trivial. :-p
>>>>
>>>> -Ravi (rpokala@)
>>>>
>>>
>>> I hope, commit hook will be improved some day. Pushing of two-dozen
>>> commits one by one is too boring.
>>
>> The history is in the right order and gitlog/cgit/anything that reads the log
>> show everything in the right order.
>>
>> mails are asynchronuous, expecting the mail to always arrive in a given order is
>> wrong ;)
>>
>> pushing all those commits at once was imho the right thing to do.
>>
>
> I've pointed this out a couple of times (with seemingly nothing coming
> from it), but the mails are being sent in reverse order. Fixing that
> would at least increase chances for some to receive them in order (and
> the archives show them perfectly in reverse order most of the time).
>
> Picking out the message-ids from the last series I sent, this is the
> correct order:
>
> 202101072237.107MbYaX002789@gitrepo.freebsd.org ("4832d2e8ae1d - main
> - du: tests: fix the H_flag test (primarily grep usage)")
> 202101072237.107MbYsM002771@gitrepo.freebsd.org ("3c5c39c7ad8f - main
> - du: tests: make H_flag tests more strict about output requirements")
>
> 202101072237.107MbYaX002789 -> 2789 was the last pid that assigned a message-id
> 202101072237.107MbYsM002771 -> 2771 was the last pid that assigned a message-id
>
> Given that this is clearly with kern.randompid=0 on the server, one
> can conclude that these were sent in the reverse order based on the
> pid sequence. If you pick a couple other series out, this holds true
> (at least for all the series I've looked at)
I believe Li-wen and Uli tracked this down today and that this might be
fixed going forward (needed to add --reverse to git rev-list to build
the list of commits to generate e-mails for)
--
John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4628ea93-876c-be1c-1012-bc4353e0b31d>