From owner-cvs-lib  Tue Oct 14 00:24:45 1997
Return-Path: <owner-cvs-lib>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id AAA29589
          for cvs-lib-outgoing; Tue, 14 Oct 1997 00:24:45 -0700 (PDT)
          (envelope-from owner-cvs-lib)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
          by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id AAA29536;
          Tue, 14 Oct 1997 00:24:12 -0700 (PDT)
          (envelope-from bde@FreeBSD.org)
From: Bruce Evans <bde@FreeBSD.ORG>
Received: (from bde@localhost)
	by freefall.freebsd.org (8.8.6/8.8.5) id AAA25666;
	Tue, 14 Oct 1997 00:23:20 -0700 (PDT)
Date: Tue, 14 Oct 1997 00:23:20 -0700 (PDT)
Message-Id: <199710140723.AAA25666@freefall.freebsd.org>
To: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-lib@FreeBSD.ORG
Subject: cvs commit: src/lib/libc/gen exec.3 exec.c
Sender: owner-cvs-lib@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

bde         1997/10/14 00:23:20 PDT

  Modified files:
    lib/libc/gen         exec.3 exec.c 
  Log:
  Fixed searching of $PATH in execvp().  Do what sh(1) should do according
  to POSIX.2.  In particular:
  
  - don't retry for ETXTBSY.  This matches what sh(1) does.  The retry code
    was broken anyway.  It only slept for several seconds for the first few
    retries.  Then it retried without sleeping.
  - don't abort the search for errors related to the path prefix, in
    particular for ENAMETOOLONG, ENOTDIR, ELOOP.  This fixes PR1487.  sh(1)
    gets this wrong in the opposite direction by never aborting the search.
  - don't confuse EACCES for errors related to the path prefix with EACCES
    for errors related to the file.  sh(1) gets this wrong.
  - don't return a stale errno when the search terminates normally without
    finding anything.  The errno for the last unsuccessful execve() was
    usually returned.  This gave too much precedence to pathologies in the
    last component of $PATH.  This bug is irrelevant for sh(1).
  
  The implementation still uses the optimization/race-inhibitor of trying
  to execve() things first.  POSIX.2 seems to require looking at file
  permissions using stat().  We now use stat() after execve() if execve()
  fails with an ambiguous error.  Trying execve() first may actually be a
  pessimization, since failing execve()s are fundamentally a little slower
  than stat(), and are significantly slower when a file is found but has
  unsuitable permissions or points to an unsuitable interpreter.
  
  PR:		1487
  
  Revision  Changes    Path
  1.6       +51 -17    src/lib/libc/gen/exec.3
  1.6       +36 -9     src/lib/libc/gen/exec.c