Date: Thu, 2 Feb 2023 23:08:50 +0000 From: Jessica Clarke <jrtc27@freebsd.org> To: Dimitry Andric <dim@FreeBSD.org> Cc: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@FreeBSD.org>, "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: fb53e7adaf5b - main - tarfs: Fix 32-bit build. Message-ID: <BDDF9FE1-2CC7-4A3D-85A6-D2DACA1B2DB9@freebsd.org> In-Reply-To: <7AB1A313-19CD-4A37-BB7D-22BD384BE327@FreeBSD.org> References: <202302022039.312KdedK078659@gitrepo.freebsd.org> <7AB1A313-19CD-4A37-BB7D-22BD384BE327@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2 Feb 2023, at 23:04, Dimitry Andric <dim@FreeBSD.org> wrote: >=20 > On 2 Feb 2023, at 21:39, Dag-Erling Sm=C3=B8rgrav <des@FreeBSD.org> = wrote: >>=20 >> The branch main has been updated by des: >>=20 >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dfb53e7adaf5b45ca08f650babc40077d= eff5e9af >>=20 >> commit fb53e7adaf5b45ca08f650babc40077deff5e9af >> Author: Dag-Erling Sm=C3=B8rgrav <des@FreeBSD.org> >> AuthorDate: 2023-02-02 20:36:01 +0000 >> Commit: Dag-Erling Sm=C3=B8rgrav <des@FreeBSD.org> >> CommitDate: 2023-02-02 20:39:10 +0000 >>=20 >> tarfs: Fix 32-bit build. >>=20 >> Sponsored by: Juniper Networks, Inc. >> Sponsored by: Klara, Inc. > ... >> --- a/sys/fs/tarfs/tarfs_subr.c >> +++ b/sys/fs/tarfs/tarfs_subr.c >> @@ -137,7 +137,7 @@ tarfs_print_node(struct tarfs_node *tnp) >> printf("\tvnode %p\n", tnp->vnode); >> printf("\ttmp %p\n", tnp->tmp); >> printf("\ttype %d\n", tnp->type); >> - printf("\tino %lu\n", tnp->ino); >> + printf("\tino %lu\n", (unsigned long)tnp->ino); >> printf("\tsize %zu\n", tnp->size); >> printf("\tname %s\n", >> (tnp->name =3D=3D NULL) ? "<<root>>" : tnp->name); >> @@ -146,7 +146,7 @@ tarfs_print_node(struct tarfs_node *tnp) >> printf("\tgid %d\n", tnp->gid); >> printf("\tmode o%o\n", tnp->mode); >> printf("\tflags %u\n", tnp->flags); >> - printf("\tnlink %lu\n", tnp->nlink); >> + printf("\tnlink %lu\n", (unsigned long)tnp->nlink); >> printf("\tatime %d\n", (int)tnp->atime.tv_sec); >> printf("\tmtime %d\n", (int)tnp->mtime.tv_sec); >> printf("\tctime %d\n", (int)tnp->ctime.tv_sec); >=20 > This be just nitpicking, but the ino and nlink fields are typically > defined as int64_t and uint64_t, so these should be printed as such. >=20 > Since PRId64 and PRIu64 are apparently frowned upon, the usual = solution > is to cast everything to intmax_t or uintmax_t, and use %j for the > modifier. The casts of what I assume are time_t to int are also concerning. Jess
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BDDF9FE1-2CC7-4A3D-85A6-D2DACA1B2DB9>