From owner-freebsd-current@FreeBSD.ORG Mon Aug 22 21:35:57 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 906D3106564A; Mon, 22 Aug 2011 21:35:57 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from mail-gy0-f182.google.com (mail-gy0-f182.google.com [209.85.160.182]) by mx1.freebsd.org (Postfix) with ESMTP id 1F7648FC08; Mon, 22 Aug 2011 21:35:56 +0000 (UTC) Received: by gyd10 with SMTP id 10so4404226gyd.13 for ; Mon, 22 Aug 2011 14:35:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:date:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=3yCxoyJFEcrtm+OJ3MfN2BzLimMlIvBA5JXPEumgPjQ=; b=p451xAwezjJ5AjOb0L809dUK2p/+3rRBV6hS8xBjeg31ZKpwJvIm9YiGAkOwejQm/Z DM3pD4dORfcqBT44kZBih7CtOhV1kr7ZDVvcWt8+se6C6Veeuijcg9kfKKs9cjFyvfND ZlX0S04HUwquJ1Ak+JzYd+F6LorfsEpb88tG8= Received: by 10.101.212.12 with SMTP id o12mr1027110anq.31.1314048956363; Mon, 22 Aug 2011 14:35:56 -0700 (PDT) Received: from pyunyh@gmail.com ([174.35.1.224]) by mx.google.com with ESMTPS id e4sm5571933anb.15.2011.08.22.14.35.54 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 22 Aug 2011 14:35:55 -0700 (PDT) Received: by pyunyh@gmail.com (sSMTP sendmail emulation); Mon, 22 Aug 2011 14:35:49 -0700 From: YongHyeon PYUN Date: Mon, 22 Aug 2011 14:35:49 -0700 To: Garrett Cooper Message-ID: <20110822213549.GC4452@michelle.cdnetworks.com> References: <20110821234856.GB1755@michelle.cdnetworks.com> <20110822204054.GB4452@michelle.cdnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Cc: mdf@freebsd.org, FreeBSD Current , Pyun YongHyeon Subject: Re: Deterministic panic due to non-sleepable lock with if_alc when reconfiguring interfaces X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Aug 2011 21:35:57 -0000 On Mon, Aug 22, 2011 at 02:26:47PM -0700, Garrett Cooper wrote: > On Mon, Aug 22, 2011 at 1:40 PM, YongHyeon PYUN wrote: > > On Sun, Aug 21, 2011 at 04:48:56PM -0700, YongHyeon PYUN wrote: > >> On Fri, Aug 19, 2011 at 12:17:12AM -0700, Garrett Cooper wrote: > >> > On Thu, Aug 18, 2011 at 9:31 PM, ? wrote: > >> > > On Thu, Aug 18, 2011 at 5:50 PM, Garrett Cooper wrote: > >> > >> ? ?When loading if_alc as a module on my netbook and running > >> > >> /etc/rc.d/netif restart, I can deterministically panic my netbook with > >> > >> the following message: > >> > > >> > ? ? These repro steps were overly simplified. The complete steps are: > >> > > >> > 1. Attach ethernet cable to alc(4) enabled NIC. > >> > 2. Boot up machine. > >> > 3. Login. > >> > 4. Physically remove ethernet cable from alc(4) enabled NIC. > >> > 5. Run `/etc/rc.d/netif restart' as root. > >> > > >> > >> I can't reproduce this with AR8151 sample board. Could you give me > >> dmesg output to know exact controller revision? > >> One issue I'm aware of is lack of re-establishing link when > >> controller firmware put its PHY to deep sleep mode. ?The deep sleep > >> mode seems to be automatically activated by firmware when it > >> detects no energy signal(i.e. cable unplugged) so I had to down and > >> up the interface again to take the PHY out of the sleep mode. > >> > > > > Not re-establishing link issue was fixed in r225088. ?I'm not sure > > whether this also fixes kern/148772 though. Because you also seem > > to have the same issue of the PR, it would be good to know whether > > it makes any difference or not. > > The panic no longer occurs with that commit when running > /etc/rc.d/netif restart after inserting and reinserting the ethernet > cable (I've done it several times for good measure); the failing case > was potentially being triggered somehow by the hibernation code path. Hmm, have no idea how this can be related with the panic. :-( BTW, does the commit also fix kern/148772? > Thanks, > -Garrett >