From owner-svn-src-all@freebsd.org Thu May 19 12:07:38 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8E35AB42D04; Thu, 19 May 2016 12:07:38 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from citapm.icyb.net.ua (citapm.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 0BAE51255; Thu, 19 May 2016 12:07:36 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citapm.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id PAA24495; Thu, 19 May 2016 15:07:34 +0300 (EEST) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1b3Mjm-000MCx-7d; Thu, 19 May 2016 15:07:34 +0300 Subject: Re: svn commit: r300113 - in head/sys: conf kern net sys To: Kristof Provost , Scott Long References: <201605180435.u4I4ZwYh025096@repo.freebsd.org> <0C9937A7-792B-4339-ACF9-F5D7D3C3A85A@FreeBSD.org> Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org From: Andriy Gapon Message-ID: <2013f2c5-94f0-6e1d-0a58-a4a33005e74d@FreeBSD.org> Date: Thu, 19 May 2016 15:06:13 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <0C9937A7-792B-4339-ACF9-F5D7D3C3A85A@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 May 2016 12:07:38 -0000 On 19/05/2016 14:37, Kristof Provost wrote: > > > On 18 May 2016, at 10:05, Scott Long wrote: > >> Author: scottl >> Date: Wed May 18 04:35:58 2016 >> New Revision: 300113 >> URL: https://svnweb.freebsd.org/changeset/base/300113 >> >> Log: >> Import the 'iflib' API library for network drivers. From the author: > > For reasons I don’t understand right now this appears to break boot on my T61. > It’s got an em NIC (82566MM) and is running root-on-zfs, if that matters. > > It mounts the rootfs and then just freezes. I’m investigating, but would > appreciate any hints or thoughts. Alexander has just committed r300201. It should help. > >> Modified: head/sys/kern/subr_taskqueue.c >> ============================================================================== >> --- head/sys/kern/subr_taskqueue.c Wed May 18 04:04:14 2016 (r300112) >> +++ head/sys/kern/subr_taskqueue.c Wed May 18 04:35:58 2016 (r300113) >> @@ -119,11 +123,17 @@ TQ_SLEEP(struct taskqueue *tq, void *p, >> } >> >> static struct taskqueue * >> -_taskqueue_create(const char *name __unused, int mflags, >> +_taskqueue_create(const char *name, int mflags, >> taskqueue_enqueue_fn enqueue, void *context, >> - int mtxflags, const char *mtxname) >> + int mtxflags, const char *mtxname __unused) >> { >> struct taskqueue *queue; >> + char *tq_name = NULL; >> + >> + if (name != NULL) >> + tq_name = strndup(name, 32, M_TASKQUEUE); >> + if (tq_name == NULL) >> + tq_name = "taskqueue"; > > This looks wrong. It’s later free()ed. > >> >> @@ -194,6 +206,7 @@ taskqueue_free(struct taskqueue *queue) >> KASSERT(queue->tq_callouts == 0, ("Armed timeout tasks")); >> mtx_destroy(&queue->tq_mutex); >> free(queue->tq_threads, M_TASKQUEUE); >> + free(queue->tq_name, M_TASKQUEUE); > > This potentially frees a constant pointer. > > Regards, > Kristof > -- Andriy Gapon