From owner-svn-src-all@FreeBSD.ORG Mon Aug 17 15:36:13 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 41BC51065690; Mon, 17 Aug 2009 15:36:13 +0000 (UTC) (envelope-from sam@errno.com) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.freebsd.org (Postfix) with ESMTP id 042598FC55; Mon, 17 Aug 2009 15:36:12 +0000 (UTC) Received: from ice.local ([10.0.0.115]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id n7HFaCIm011848 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 17 Aug 2009 08:36:12 -0700 (PDT) (envelope-from sam@errno.com) Message-ID: <4A8978EC.101@errno.com> Date: Mon, 17 Aug 2009 08:36:12 -0700 From: Sam Leffler User-Agent: Thunderbird 2.0.0.22 (Macintosh/20090605) MIME-Version: 1.0 To: Pawel Jakub Dawidek References: <200908170842.n7H8gYo5054777@svn.freebsd.org> In-Reply-To: <200908170842.n7H8gYo5054777@svn.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DCC--Metrics: ebb.errno.com; whitelist Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r196293 - head/sys/kern X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Aug 2009 15:36:13 -0000 Pawel Jakub Dawidek wrote: > Author: pjd > Date: Mon Aug 17 08:42:34 2009 > New Revision: 196293 > URL: http://svn.freebsd.org/changeset/base/196293 > > Log: > Because taskqueue_run() can drop tq_mutex, we need to check if the > TQ_FLAGS_ACTIVE flag wasn't removed in the meantime, which means we missed a > wakeup. So this would leave a task q thread running? Can you describe the scenario that demonstrated this problem? Sam