From owner-p4-projects@FreeBSD.ORG  Sun Aug  3 14:02:40 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 4B2DF1065680; Sun,  3 Aug 2008 14:02:40 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EA797106567A
	for <perforce@freebsd.org>; Sun,  3 Aug 2008 14:02:39 +0000 (UTC)
	(envelope-from gabor@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id D09958FC1A
	for <perforce@freebsd.org>; Sun,  3 Aug 2008 14:02:39 +0000 (UTC)
	(envelope-from gabor@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.2/8.14.2) with ESMTP id m73E2dfI032257
	for <perforce@freebsd.org>; Sun, 3 Aug 2008 14:02:39 GMT
	(envelope-from gabor@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.2/8.14.1/Submit) id m73E2dAI032255
	for perforce@freebsd.org; Sun, 3 Aug 2008 14:02:39 GMT
	(envelope-from gabor@freebsd.org)
Date: Sun, 3 Aug 2008 14:02:39 GMT
Message-Id: <200808031402.m73E2dAI032255@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	gabor@freebsd.org using -f
From: Gabor Kovesdan <gabor@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 146523 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 03 Aug 2008 14:02:40 -0000

http://perforce.freebsd.org/chv.cgi?CH=146523

Change 146523 by gabor@gabor_server on 2008/08/03 14:02:14

	- Don't implement features as noop, it is not a good idea.
	
	Prodded by:	kris

Affected files ...

.. //depot/projects/soc2008/gabor_textproc/diff/diff.c#16 edit

Differences ...

==== //depot/projects/soc2008/gabor_textproc/diff/diff.c#16 (text+ko) ====

@@ -66,7 +66,7 @@
 	NOOP_OPT
 };
 
-#define	OPTIONS	"0123456789abC:cdD:eF:fhI:iL:lnNPpqrS:sTtU:uvwW:X:x:y"
+#define	OPTIONS	"0123456789abC:cdD:efhI:iL:lnNPpqrS:sTtU:uvwX:x:"
 static struct option longopts[] = {
 	{ "ignore-file-name-case",	no_argument,		NULL,	FCASE_IGNORE_OPT },
 	{ "no-ignore-file-name-case",	no_argument,		NULL,	FCASE_SENSITIVE_OPT },
@@ -109,13 +109,15 @@
 	{ "ignore-all-space",		no_argument,		NULL,	'w' },
 	{ "exclude-from",		required_argument,	NULL,	'X' },
 	{ "exclude",			required_argument,	NULL,	'x' },
-/* Compatibility options, which are noop.  We only pretend to support them. */
+	{ "speed-large-files",          no_argument,            NULL,   NOOP_OPT },
+/* XXX: the following are not very well documented and rarely used. If we need
+        them at all, we will need to dig into the code to see what do they do
+        actually.
 	{ "horizon-lines",		required_argument,	NULL,	NOOP_OPT },
 	{ "left-column",		no_argument,		NULL,	NOOP_OPT },
 	{ "line-format",                required_argument,      NULL,   NOOP_OPT },
 	{ "show-function-line",		required_argument,	NULL,	'F' },
 	{ "side-by-side",		no_argument,		NULL,	'y' },
-	{ "speed-large-files",		no_argument,		NULL,	NOOP_OPT },
 	{ "suppress-common-lines",	no_argument,		NULL,	NOOP_OPT },
 	{ "width",			optional_argument,	NULL,	'W' },
 	{ "unchanged-group-format",	required_argument,	NULL,	NOOP_OPT },
@@ -124,7 +126,8 @@
 	{ "changed-group-format",	required_argument,	NULL,	NOOP_OPT },
 	{ "unchanged-line-format",	required_argument,	NULL,	NOOP_OPT },
 	{ "old-line-format",		required_argument,	NULL,	NOOP_OPT },
-	{ "new-line-format",		required_argument,	NULL,	NOOP_OPT },	
+	{ "new-line-format",		required_argument,	NULL,	NOOP_OPT },
+*/
 	{ NULL,				0,			NULL,	'\0'}
 };