From owner-freebsd-hackers Fri Jun 4 13: 0: 3 1999 Delivered-To: freebsd-hackers@freebsd.org Received: from mail1.its.rpi.edu (mail1.its.rpi.edu [128.113.100.7]) by hub.freebsd.org (Postfix) with ESMTP id 3F36B15A99 for ; Fri, 4 Jun 1999 12:59:59 -0700 (PDT) (envelope-from drosih@rpi.edu) Received: from [128.113.24.47] (gilead.acs.rpi.edu [128.113.24.47]) by mail1.its.rpi.edu (8.8.8/8.8.6) with ESMTP id PAA110920; Fri, 4 Jun 1999 15:59:57 -0400 Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <19990604091857.25082.qmail@alice.gba.oz.au> References: <199906031735.NAA37037@cs.rpi.edu> of Thu, 03 Jun 1999 13:35:19 -0400 <199906031735.NAA37037@cs.rpi.edu> Date: Fri, 4 Jun 1999 16:00:35 -0400 To: Greg Black , "David E. Cross" From: Garance A Drosihn Subject: Re: 3.2-stable, panic #12 Cc: freebsd-hackers@FreeBSD.ORG Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG At 7:18 PM +1000 6/4/99, Greg Black wrote: >"David E. Cross" writes: > >> fd=open(argv[1], O_CREAT, 600); > > Since this opens the file so that it cannot be written to, not > to mention the really weird mode it will get if it's created by > that open(), the rest of the thing doesn't deserve to work. > > Generally speaking, it's a good idea to make sure that test code > is at least decent before starting to puzzle over what it does. So, are you saying that it is perfectly reasonable that this less-than-pretty user-written code, running on remote machines, and requiring absolutely no special privs, will crash FreeBSD used as an NFS server? I don't care if the code "works", or SEGV's, or if the user is logged off for being stupid, but I really do not think it is acceptable for the *file-server* to crash. The odd parameters to open() probably explains why some code-path in the system is getting confused, but it is still the OS's responsibility to keep running even when users do odd things. --- Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu Senior Systems Programmer or drosih@rpi.edu Rensselaer Polytechnic Institute To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message