Date: Sat, 21 Feb 2015 13:19:19 +0100 From: Jan Beich <jbeich@FreeBSD.org> To: John Marino <freebsd.contact@marino.st> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, marino@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r379485 - in head: mail/thunderbird/files www/firefox-esr/files www/libxul/files Message-ID: <4mqf-78zc-wny@FreeBSD.org> References: <201502210822.t1L8MSNt008911@svn.freebsd.org> <54E8444B.4090707@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
--=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable John Marino <freebsd.contact@marino.st> writes: >> Author: jbeich >> Date: Sat Feb 21 08:22:28 2015 >> New Revision: 379485 >> URL: https://svnweb.freebsd.org/changeset/ports/379485 >> QAT: https://qat.redports.org/buildarchive/r379485/ >>=20 >> Log: >> Fix invalid conversions of nullptr to bool to unbreak clang 3.6 build >>=20=20=20 >> PR: 197857 >> Submitted by: dim (initial version) >> Obtained from: https://github.com/mozilla/gecko-dev/commit/dd19f59 >>=20 > > All the mozilla stuff is busted on gcc5 for this reason: firefox, > seamonkey, libxul, thunderbird. I have high hopes this patch fixes it. > Are you planning to patch them all? Isn't USES=3Dcompiler:c++11-lang supposed to pick Clang over GCC? This commit only backports the fix from Firefox 32, SeaMonkey 2.29. If you haven't filed a bug don't expect me to know about the issue. My testing is limited due to not having a buildfarm/fast hardware while (any) GCC requires more memory/buildtime than Clang + extra time spent building the compiler itself. So, just knowing which file/which line fails to compile would have saved a lot of time. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQF8BAEBCgBmBQJU6HfHXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQjQ0MzY3NEM3RDIzNTc4NkUxNDkyQ0VF NEM3Nzg4MzQ3OURCRERCAAoJEOTHeINHnb3bM6YIAKac9gVUkQT52JsAtKZ/BkxU FTB5nQbu7hzjObclcdgG0BnGv3boOMq+00nE14Szwz0igtuHJjgJzQCYZi0PoRHC 2sNEk7jVpxlJlbb8/egBCuyCCPPkCKcxgsfr5zJF/4CLtU3RDrszJ4XdD7V3te2U cTQao9DFSHsgJ+6eG2ms98NZ1qjjJ5Z7kx1/j3Yy6wwj2w3BYrU7IES35RQmXZ14 cGkICTOkMzvV7xP2r58Qhp/9f1aNKA7kKa08/gZwknoxYFT5FAkZyv1kAt6RmCh9 XsnRgwBJGbEZe3/Iive0mwDaRIEBgVqdey0ITysq5rUqJ2JTOOqv5p8FWk1CpHQ= =x1fw -----END PGP SIGNATURE----- --=-=-=--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4mqf-78zc-wny>