From nobody Mon Oct 17 14:55:22 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MrgCz13kxz4g8gc; Mon, 17 Oct 2022 15:00:47 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from sprint-2.amdmi3.ru (sprint-2.amdmi3.ru [IPv6:2a0a:2b41:94:cb5e::]) by mx1.freebsd.org (Postfix) with ESMTP id 4MrgCy1wFzz3HhH; Mon, 17 Oct 2022 15:00:46 +0000 (UTC) (envelope-from amdmi3@amdmi3.ru) Received: from amdmi3.ru (localhost [127.0.0.1]) by sprint-2.amdmi3.ru (Postfix) with SMTP id 5473B188E77; Mon, 17 Oct 2022 18:01:20 +0300 (MSK) Received: by amdmi3.ru (nbSMTP-1.00) for uid 1000 amdmi3@amdmi3.ru; Mon, 17 Oct 2022 18:01:20 +0300 (MSK) Date: Mon, 17 Oct 2022 17:55:22 +0300 From: Dmitry Marakasov To: Adam Weinberger Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 09c8b6c737f2 - main - games/powder-toy: Use USES=luajit (defaults to luajit-devel) Message-ID: References: <202210150120.29F1KoYq034805@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspamd-Queue-Id: 4MrgCy1wFzz3HhH X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of amdmi3@amdmi3.ru has no SPF policy when checking 2a0a:2b41:94:cb5e::) smtp.mailfrom=amdmi3@amdmi3.ru X-Spamd-Result: default: False [-1.91 / 15.00]; AUTH_NA(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.99)[-0.995]; NEURAL_HAM_MEDIUM(-0.92)[-0.917]; MIME_GOOD(-0.10)[text/plain]; RCVD_NO_TLS_LAST(0.10)[]; MLMMJ_DEST(0.00)[dev-commits-ports-all@freebsd.org,dev-commits-ports-main@freebsd.org]; R_SPF_NA(0.00)[no SPF record]; R_DKIM_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; FREEFALL_USER(0.00)[amdmi3]; TO_DN_SOME(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; DMARC_NA(0.00)[amdmi3.ru]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ASN(0.00)[asn:35278, ipnet:2a0a:2b41::/32, country:RU] X-ThisMailContainsUnwantedMimeParts: N * Adam Weinberger (adamw@freebsd.org) wrote: > > diff --git a/games/powder-toy/Makefile b/games/powder-toy/Makefile > > index 9f3669ed3c41..83404aceaedb 100644 > > --- a/games/powder-toy/Makefile > > +++ b/games/powder-toy/Makefile > > @@ -1,6 +1,7 @@ > >  PORTNAME=    powder-toy > >  PORTVERSION= 96.2.350 > >  DISTVERSIONPREFIX=   v > > +PORTREVISION=        1 > >  CATEGORIES=  games > >  > >  MAINTAINER=  amdmi3@FreeBSD.org > > @@ -13,14 +14,13 @@ LICENSE_FILE=     ${WRKSRC}/LICENSE > >  > >  LIB_DEPENDS= libfftw3f.so:math/fftw3-float \ > >               libfftw3.so:math/fftw3 \ > > -             libluajit-5.1.so:lang/luajit-openresty \ > >               libcurl.so:ftp/curl > >  > >  USE_GITHUB=  yes > >  GH_ACCOUNT=  The-Powder-Toy > >  GH_PROJECT=  The-Powder-Toy > >  > > -USES=                compiler:c++11-lang meson pkgconfig python:build > sdl > > +USES=                compiler:c++11-lang luajit meson pkgconfig > python:build sdl > >  USE_SDL=     sdl2 > >  > >  PORTDOCS=    README.md changelog.txt > > This change is invalid, as it changes dependency from luajit-openresty > to luajit-devel. Please revert or change it to depend on openresty, as > luajit is broken and leads to segfaults. Same for minetest, for the > record. > > > Done. Strange that they behave badly; Powder Toy's repo links specifically to > luajit-devel's repo, and minetest says that it works with luajit 2.0+. > > That's the unfortunate part of the luajit fragmentation that we have in the > tree. Because lang/luajit is so old, it's not clear whether a luajit-openresty > dep means "this requires openresty" vs "I don't want to depend on the old > version." They all compile cleanly, so I tried to use upstreams to guide the > conversion. Thank you! The problem with luajit may be specific to FreeBSD. I've seen an explanation from someone knowledgeable in some PR, AFAIR it was something about addess space. With that I've got an imression that all versions of upstream luajit are broken, and only openresty works. Maybe it makes sense to retest with luajit-devel, as it's preferrable to stay on default to avoid conflicts, but for now only openresty it known to be safe. Btw why don't we drop luajit completely and replace it with -devel? -- Dmitry Marakasov . amdmi3@amdmi3.ru ..: https://github.com/AMDmi3 https://amdmi3.ru/