From owner-svn-src-all@FreeBSD.ORG  Sat Oct 27 21:59:13 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id E9C96870;
 Sat, 27 Oct 2012 21:59:12 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.117])
 by mx1.freebsd.org (Postfix) with ESMTP id 5EC238FC08;
 Sat, 27 Oct 2012 21:59:12 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.5/8.14.5) with ESMTP id q9RLx7OI019632;
 Sun, 28 Oct 2012 01:59:07 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.5/8.14.5/Submit) id q9RLx7I4019631;
 Sun, 28 Oct 2012 01:59:07 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Sun, 28 Oct 2012 01:59:07 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Rui Paulo <rpaulo@felyko.com>
Subject: Re: svn commit: r241610 - in head: . sys/dev/usb sys/net
 sys/net80211 sys/netpfil/ipfw sys/netpfil/pf sys/sys
Message-ID: <20121027215907.GI70741@FreeBSD.org>
References: <201210161337.q9GDbtr8049924@svn.freebsd.org>
 <CAJ-Vmon8BxdbTUsOXF7kCOqO3=GuKXaHFqOqGHoGgmGV2=+6aw@mail.gmail.com>
 <A83B91C3-5A7C-4B6A-A0D8-A8EE9E6ADA64@felyko.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <A83B91C3-5A7C-4B6A-A0D8-A8EE9E6ADA64@felyko.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-src-head@FreeBSD.org, Adrian Chadd <adrian@FreeBSD.org>,
 src-committers@FreeBSD.org, svn-src-all@FreeBSD.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Oct 2012 21:59:13 -0000

On Fri, Oct 26, 2012 at 09:16:08PM -0700, Rui Paulo wrote:
R> I second Adrian's comments and I would like to add that you must NOT commit something like this, breaking the ABI, when you discussed this *ONE YEAR* ago with only two people (one of them is not very active in the networking stack). This is against all reasonable software development practices.

- This wasn't discussed privately but on svn-src-head@ mailing list. You could
  participate.

- No objections were raised one year ago. The code of if_cloners hasn't
  any single change during this year.

- If you mean that brooks@ is not very active in networking stack,
  then I will point your attention to the fact that he is the
  original author of interface cloners.

Now my questions:

- Do we have any policy that doesn't permit changing ABI in head?
- Apart from the ABI is there anything wrong with the r241610?

P.S. And yes, please don't use top-quoting on FreeBSD mailing lists:

http://www.freebsd.org/doc/en/articles/mailing-list-faq/etiquette.html

-- 
Totus tuus, Glebius.