From owner-cvs-all@FreeBSD.ORG Sun Jul 11 18:29:47 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 818D716A4CE; Sun, 11 Jul 2004 18:29:47 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 61D5743D45; Sun, 11 Jul 2004 18:29:47 +0000 (GMT) (envelope-from rwatson@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i6BITlvB081756; Sun, 11 Jul 2004 18:29:47 GMT (envelope-from rwatson@repoman.freebsd.org) Received: (from rwatson@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i6BITlS8081755; Sun, 11 Jul 2004 18:29:47 GMT (envelope-from rwatson) Message-Id: <200407111829.i6BITlS8081755@repoman.freebsd.org> From: Robert Watson Date: Sun, 11 Jul 2004 18:29:47 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/kern uipc_socket.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Jul 2004 18:29:47 -0000 rwatson 2004-07-11 18:29:47 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Add additional annotations to soreceive(), documenting the effects of locking on 'nextrecord' and concerns regarding potentially inconsistent or stale use of socket buffer or stack fields if they aren't carefully synchronized whenever the socket buffer mutex is released. Document that the high-level sblock() prevents races against other readers on the socket. Also document the 'type' logic as to how soreceive() guarantees that it will only return one of normal data or inline out-of-band data. Revision Changes Path 1.199 +35 -1 src/sys/kern/uipc_socket.c