From owner-ctm-users@FreeBSD.ORG Thu Jan 21 00:07:37 2010 Return-Path: Delivered-To: ctm-users@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 697F01065672 for ; Thu, 21 Jan 2010 00:07:37 +0000 (UTC) (envelope-from smckay@internode.on.net) Received: from ipmail03.adl6.internode.on.net (ipmail03.adl6.internode.on.net [203.16.214.141]) by mx1.freebsd.org (Postfix) with ESMTP id E54598FC17 for ; Thu, 21 Jan 2010 00:07:36 +0000 (UTC) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApsEAGYmV0t20IpU/2dsb2JhbACBRtdUhDYE Received: from ppp118-208-138-84.lns20.bne1.internode.on.net (HELO dungeon.home) ([118.208.138.84]) by ipmail03.adl6.internode.on.net with ESMTP; 21 Jan 2010 10:22:16 +1030 Received: from dungeon.home (localhost [127.0.0.1]) by dungeon.home (8.14.3/8.14.3) with ESMTP id o0KNpsh3006649; Thu, 21 Jan 2010 09:51:54 +1000 (EST) (envelope-from mckay) Message-Id: <201001202351.o0KNpsh3006649@dungeon.home> To: "Julian H. Stacey" References: <201001201203.o0KC3r5E036646@fire.js.berklix.net> In-Reply-To: <201001201203.o0KC3r5E036646@fire.js.berklix.net> from "Julian H. Stacey" at "Wed, 20 Jan 2010 13:03:52 +0100" Date: Thu, 21 Jan 2010 09:51:54 +1000 From: Stephen McKay Cc: ctm-users@freebsd.org, Andre Albsmeier , Stephen McKay Subject: Re: No deltas via email anymore? X-BeenThere: ctm-users@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CTM User discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jan 2010 00:07:37 -0000 On Wednesday, 20th January 2010, "Julian H. Stacey" wrote: >75 seems low, considering MS addicts write extremely long >lines at times (I suppose that's why - sigh). > > uuencode 61 > fmt 65 > MIME base64 72 > punch cards 72 > MSexchange 75 > ctm_rmail 76 > >I guess there would be no objection if you wrote patches for: > - ctm_rmail to also support receipt of smaller lines. > - ctm_smail to optionally generate shorter lines. It would be trivial to change ctm_smail to send lines of 72 characters. It would reduce the encoding efficiency slightly, but not enough to worry about. It is not worth making it optional. I'll probably do this when I get a moment. Changing ctm_rmail to attempt to repair various mangling of the input is more difficult and unlikely to be worth the trouble. If ctm_smail is changed, only new shorter lines will show up in future messages and no mangling should occur then anyway. >> From: Andre Albsmeier >> Now the deltas arrive like this: >> >> CTM_MAIL BEGIN src-7.0895.gz 1 1 >> H4sIAGI5VksCA8VZ+28bNxL+2foreG5R2HnIfD8ctEASO70AqVs0PlyvdweBT3sRaVe3u0riHvq >> / >> 35ArPyT5IbcBzoZJaUkOZz4OZ75Zvz79YfLq+Pu3J4iOMepa/1whbQSimGBMiKFUGC5/RePR69M >> f >> 3rxHY9/PJl1v+0WHYAYfGsk50h4bE3RyRmEeXJSBGSqtY1GHEKlCSQdtVBJEU8yoEEQIzw1LQhj >> L Amusingly, this uncovered a 15 year old bug in ctm_rmail. Sorry about that. :-) The decode_line() routine has no way of reporting successful decoding with a 0 length output. The "illegal character" error is spurious. ctm_rmail: line 3: illegal character: '/' ctm_rmail: src-7.0895.gz 1/1 discarded The true error report should have been a checksum failure after the whole file had been read. However, since this is only a cosmetic error on corrupt input with no security implications (no array bounds exceeded, for example), we can leave this one. Alternatively, if people feel the need for more checking, I could add code to reject line lengths that are not a multiple of 4, and perhaps to skip blank lines. Yes? Stephen. (No, not the other Stephen!)