From owner-svn-src-head@freebsd.org Tue Apr 30 15:24:38 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 83FAE1595658 for ; Tue, 30 Apr 2019 15:24:38 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com [IPv6:2607:f8b0:4864:20::82b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 219A9771BA for ; Tue, 30 Apr 2019 15:24:38 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x82b.google.com with SMTP id e2so15849632qtb.4 for ; Tue, 30 Apr 2019 08:24:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Yl2EMt15elu4oxf2JGGS6wqU0GrIaki3oQhxCPfnaow=; b=MtPKNmISxOGeOcuDPlil+B6yJsGxfVkO8FPRorYRJdzbPpyg3Xp/fTmlO4mhotBvr4 NCQeVBB/gLXghn4ocxuiaIR1WUm2MdV1ClEAmfGJcZT5w4E6L4NtG1Qk4cF/8PxE/MM5 sF0Vdkw1Kr65wD3XrUeRjr2Zwq99z4zbyVZ20f5GlPyWOeRyTDvbIISZjzRYxTvquXDn NmaC0KajhMnUiQdLNaa3NmQtdO1VhrlXC/m+XtXjGoSfYMnS4qMk+vmuX7grIxUoHbws KyqM9jd18XHBSbr9IiZTy6GLB2AZBEVL31W1jWrt38JgDsWZ/SIh4OtC19Gqi/crDeKN YNKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Yl2EMt15elu4oxf2JGGS6wqU0GrIaki3oQhxCPfnaow=; b=txJTG6u4OUDhv2oWH45Ps7At3jF+NDGAWx3Jc07/co0g24JJDA8q8L+sZcxtDCCnML vuGJD9Lw67IbYFjhLPsoV8sHi4s6DPYzXj08fhmeWuSCjlyHu7dYYy/ZVWyyyajdNKt/ DYa4gA9gUoSAqbDIxHBu5mLJ8CPWBODi6Fh+S0ucvquo7jMJdSFnykrixlOfUp0Xq4ZY lHNAszWQAAmdGtSvw5AFm0j0VvfVPCyoLkINYTqDd+6iKUhkZ6WHi1PK8GbY1sZE0Coi XSezrVtcMVDTrtXrgnu1Fe5fo0nuPW4NhHxzhQ+YLSQGYgHuprgoRunDS/FpjB/cL/uM HXyg== X-Gm-Message-State: APjAAAUXkajxDMghC+RQ99d07olJdnOFr5qpcH9DavEWD/WKuvqFZBmQ xENSO1H2YKvIQFQLHNmOF7BP7+GCeWg1bFqTSufyZ2Bi X-Google-Smtp-Source: APXvYqwJvBMy+IdPrcmd61rB/pbSY8DYqM1V/8kxT8czKKEens8rgG93UxxQnkxzputbAzJCYukco++7lceOyVWEXVg= X-Received: by 2002:ac8:28d0:: with SMTP id j16mr56190135qtj.15.1556637877357; Tue, 30 Apr 2019 08:24:37 -0700 (PDT) MIME-Version: 1.0 References: <201904301041.x3UAfLvj054368@repo.freebsd.org> <8f360678-2df1-fe7b-cb83-f47923534826@freebsd.org> <2f77d9f2-833d-f614-e193-a369086c01cf@selasky.org> In-Reply-To: <2f77d9f2-833d-f614-e193-a369086c01cf@selasky.org> From: Warner Losh Date: Tue, 30 Apr 2019 09:24:25 -0600 Message-ID: Subject: Re: svn commit: r346958 - head/sys/compat/linuxkpi/common/src To: Hans Petter Selasky Cc: Niclas Zeising , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 219A9771BA X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.990,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Apr 2019 15:24:38 -0000 On Tue, Apr 30, 2019 at 9:17 AM Hans Petter Selasky wrote: > On 4/30/19 3:10 PM, Niclas Zeising wrote: > > On 2019-04-30 12:41, Hans Petter Selasky wrote: > >> Author: hselasky > >> Date: Tue Apr 30 10:41:20 2019 > >> New Revision: 346958 > >> URL: https://svnweb.freebsd.org/changeset/base/346958 > >> > >> Log: > >> Reduce the number of mutexes after r346645 in the LinuxKPI. > >> Make function macro wrappers for locking and unlocking to ease > >> readability. > >> No functional change. > >> Discussed with: kib@, tychon@ and zeising@ > > > > I was not part of any discussion regarding this. If this is related to > > https://reviews.freebsd.org/D20097 I explicitly asked you on gitter to > > hold of for a bit, while we try to figure out why we are seeing > > regressions in graphics with the latest dmar changes. > > > > Can you please revert this since it colludes the dmar graphics issue, > > and it makes the suggested patch not apply cleanly, which makes it > > harder to get people to help test. > > Thank you! > > Regards > > In response to your request I've collected fixes for all the known > LinuxKPI+DMA issues at: > https://reviews.freebsd.org/D20097 > > It is based on top of the latest -current. > Hopefully this will solve the problem. Do you have any idea of when we might see resolution of this issue? I'd like to see it fixed by Friday either with fixes or a revert. Do you think that's a reasonable time frame? If not, what do you think a reasonable time frame will be? I know we have a number of unknowns to factor in, so my queries are based on our best guesses. Warner