From owner-freebsd-net@FreeBSD.ORG  Sat May 22 06:27:22 2010
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2DFBC106564A
	for <freebsd-net@freebsd.org>; Sat, 22 May 2010 06:27:22 +0000 (UTC)
	(envelope-from earl.lapus@gmail.com)
Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com
	[209.85.214.182])
	by mx1.freebsd.org (Postfix) with ESMTP id ED9ED8FC1C
	for <freebsd-net@freebsd.org>; Sat, 22 May 2010 06:27:21 +0000 (UTC)
Received: by iwn5 with SMTP id 5so2189451iwn.13
	for <freebsd-net@freebsd.org>; Fri, 21 May 2010 23:27:21 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:received:received:date:message-id
	:subject:from:to:content-type;
	bh=gV57RxdEvAOb8VhEUDhdcECqcQ08cYSukpO0tln9xG4=;
	b=rKmlvXO4NiyvXlnbtxi5yKEuWBfG4+nFR1ifP654jf3asE8+Y/GxFb8u+wOw+4rZlP
	t8THMLh5Y7cre7RoJso37dOK+dGTUvV8xHoUHaOgPV3PFkkbduWkK8zKtMEYdR717x6z
	p5fUX/At8JBG/KaGre1bS8XSH+YvIR8YcmSVM=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:date:message-id:subject:from:to:content-type;
	b=VEO+ZqU5IoYPXsXHqV3AJ1m/e34gwCiwPk86sn2kwLRWUmidUV+E89h7O2SsJXWnjj
	+6l1Akus45nUo5/N3SXQfmW44Dhh4aKagM2V0sRTZXmgfBhqLotzH0/HIosZ1PXGPixI
	q96wHjflhlfZnvBLjU5J6SWLMqafjd7HZEMuE=
MIME-Version: 1.0
Received: by 10.231.120.210 with SMTP id e18mr1816522ibr.84.1274509638091; 
	Fri, 21 May 2010 23:27:18 -0700 (PDT)
Received: by 10.231.146.65 with HTTP; Fri, 21 May 2010 23:27:18 -0700 (PDT)
Date: Sat, 22 May 2010 14:27:18 +0800
Message-ID: <AANLkTinjn3k5bQ00rxeZb2EVqTsu4XL3_Qz_tA3-RE3p@mail.gmail.com>
From: Earl Lapus <earl.lapus@gmail.com>
To: freebsd-net@freebsd.org
Content-Type: text/plain; charset=ISO-8859-1
Subject: patch review for kern/146534
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 22 May 2010 06:27:22 -0000

Hi,

I submitted a patch which fixes the problem described in the PR and it
also retains this
(http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/netinet6/icmp6.c.diff?r1=1.118;r2=1.119;f=h)
fix.

I also ran the TAHI (tool version REL_3_3_0; test program version
V6LC_4_0_5) phase 2 NDP test scripts and they all passed.

I'm not 100% sure that the patch is correct. The code used to check if
the original destination address is an anycast address is a bit
redundant. I hope someone from the list can have a look at it.

Cheers!
Earl

-- 
There are seven words in this sentence.