Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 22 Jan 2016 10:32:46 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Olivier Duchateau <olivierd@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r406897 - head/x11/keybinder
Message-ID:  <20160122103246.GB15265@FreeBSD.org>
In-Reply-To: <201601221005.u0MA5w0F013215@repo.freebsd.org>
References:  <201601221005.u0MA5w0F013215@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jan 22, 2016 at 10:05:58AM +0000, Olivier Duchateau wrote:
> New Revision: 406897
> URL: https://svnweb.freebsd.org/changeset/ports/406897
> 
> Log:
>   Update to 0.3.1
>   
>   PR:		206260
>   Submitted by:	<tkato432@yahoo.com>
> 
> [...]
> +post-install-EXAMPLES-on:
>  	@${MKDIR} ${STAGEDIR}${EXAMPLESDIR}
> -	${INSTALL_DATA} ${WRKSRC}/examples/* ${STAGEDIR}${EXAMPLESDIR}
> -.endif
> +	(cd ${WRKSRC}/examples && ${INSTALL_DATA} * \
> +		${STAGEDIR}${EXAMPLESDIR})

Olivier,

Please bear in mind (as it was already mentioned on the list several times
in the past on similar occasions) that Kato's PRs often contain gratuitous,
unwarranted changes that do not improve anything and should not have been
committed (the quoted part is one of that kind).

Please strip Kato's from the noise before checking them in, do not use as
is (verbatim), thank you.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160122103246.GB15265>