Date: Thu, 19 May 2016 12:09:19 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Rick Macklem <rmacklem@uoguelph.ca> Cc: Rick Macklem <rmacklem@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r299753 - head/sys/fs/fuse Message-ID: <20160519120919.GA45827@FreeBSD.org> In-Reply-To: <1941668157.102490217.1463439395249.JavaMail.zimbra@uoguelph.ca> References: <201605142003.u4EK3MwV021470@repo.freebsd.org> <20160514203542.GA21013@FreeBSD.org> <1941668157.102490217.1463439395249.JavaMail.zimbra@uoguelph.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, May 16, 2016 at 06:56:35PM -0400, Rick Macklem wrote: > Alexey Dokuchaev wrote: > > On Sat, May 14, 2016 at 08:03:22PM +0000, Rick Macklem wrote: > > > New Revision: 299753 > > > URL: https://svnweb.freebsd.org/changeset/base/299753 > > > > > > Log: > > > Fix fuse to use DIRECT_IO when required. > > > > > > When a file is opened write-only and a partial block was written, > > > buffered I/O would try and read the whole block in. This would > > > result in a hung thread, since there was no open (fuse filehandle) > > > that allowed reading. This patch avoids the problem by forcing > > > DIRECT_IO for this case. > > > It also sets DIRECT_IO when the file system specifies the FN_DIRECTIO > > > flag in its reply to the open. > > > > Since you're at fuse now, perhaps you could also have a look at PR 195000? > > > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195000 > > I was able to test the patch and it stops the crash. > I took out the MPASS() call because I didn't see why it should panic > for VFIFO instead of returning EINVAL like the rest. > > If you'd like to commit it, email soon. Otherwise I will commit it. Rick, if I could've committed it, I would've done it long time ago. ;-) I'm lucky to finaly drag competent src committer's attention to this PR. Please go ahead of course, no waiting required. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160519120919.GA45827>