From owner-freebsd-hackers@FreeBSD.ORG Sat Oct 21 17:30:25 2006 Return-Path: X-Original-To: freebsd-hackers@FreeBSD.org Delivered-To: freebsd-hackers@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3A33E16A416 for ; Sat, 21 Oct 2006 17:30:25 +0000 (UTC) (envelope-from ru@rambler-co.ru) Received: from relay0.rambler.ru (relay0.rambler.ru [81.19.66.187]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9340743D55 for ; Sat, 21 Oct 2006 17:30:21 +0000 (GMT) (envelope-from ru@rambler-co.ru) Received: from relay0.rambler.ru (localhost [127.0.0.1]) by relay0.rambler.ru (Postfix) with ESMTP id E5FB16659; Sat, 21 Oct 2006 21:30:18 +0400 (MSD) Received: from edoofus.park.rambler.ru (unknown [81.19.65.108]) by relay0.rambler.ru (Postfix) with ESMTP id 38D3C6335; Sat, 21 Oct 2006 21:25:27 +0400 (MSD) Received: (from ru@localhost) by edoofus.park.rambler.ru (8.13.8/8.13.8) id k9LHPXgo069606; Sat, 21 Oct 2006 21:25:33 +0400 (MSD) (envelope-from ru) Date: Sat, 21 Oct 2006 21:25:33 +0400 From: Ruslan Ermilov To: Jeremie Le Hen Message-ID: <20061021172533.GA69551@rambler-co.ru> References: <20061020150848.GQ53114@obiwan.tataz.chchile.org> <20061020191332.GC59856@rambler-co.ru> <20061021162635.GS53114@obiwan.tataz.chchile.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="h31gzZEtNLTqOjlF" Content-Disposition: inline In-Reply-To: <20061021162635.GS53114@obiwan.tataz.chchile.org> User-Agent: Mutt/1.5.13 (2006-08-11) X-Virus-Scanned: No virus found Cc: freebsd-hackers@FreeBSD.org Subject: Re: src.conf(5) seems to affect ports build X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Oct 2006 17:30:25 -0000 --h31gzZEtNLTqOjlF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 21, 2006 at 06:26:35PM +0200, Jeremie Le Hen wrote: > Hi Ruslan, >=20 > On Fri, Oct 20, 2006 at 11:13:32PM +0400, Ruslan Ermilov wrote: > > On Fri, Oct 20, 2006 at 05:08:48PM +0200, Jeremie Le Hen wrote: > > > Hi, > > >=20 > > > src.conf(5) manual page states: > > >=20 > > > % The src.conf file contains settings that will apply to every build > > > % involving the FreeBSD source tree; see build(7). > > > % ... > > > % The only purpose of src.conf is to control the compilation of the F= reeBSD > > > % sources, which are usually found in /usr/src. > > >=20 > > > However, share/mk/bsd.port.mk includes which in turn inc= ludes > > > /etc/src.conf. Therefore if I have some WITH_/WITHOUT_ knob in it > > > which affects CFLAGS, they will be taken into account even for port b= uilds. > > >=20 > > > Is it the expected behaviour ? Maybe WITH(OUT)_ should simply avoid > > > modifying CFLAGS (though I think this might become useful in the near > > > future). > > >=20 > > See if the attached patch helps. If it does, I'll commit. I've > > never heard back on this patch after I sent it to obrien@. >=20 > This patch works correctly. Would you explain me why assigning > /dev/null to _SRCCONF don't work in the current version of bsd.port.mk ? >=20 1) It's spelled SRCCONF. 2) Even if spelled correctly, setting it to /dev/null doesn't prevent MK_* variables to be set to their default values: cd /usr/src && make showconfig SRCCONF=3D/dev/null > Also, your patch avoids performing the WITH(OUT)_* stuff for ports in > order to prevent from polluting the namespace. If there is to be > some WITH(OUT)_* knobs which leads to CFLAGS modification in the future > (I'm thinking about ProPolice with the upcoming GCC 4.1), wouldn't it > be worth benefiting this framework for ports ? >=20 It avoids only /etc/src.conf stuff when running bsd.port.mk; if you put WITH(OUT)_* in /etc/make.conf it will still be picked up. Cheers, --=20 Ruslan Ermilov ru@FreeBSD.org FreeBSD committer --h31gzZEtNLTqOjlF Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (FreeBSD) iD8DBQFFOlgNqRfpzJluFF4RApsRAJ4hSp2dJw34mracQEvuNSBFxaMZCgCfXzhW h+rGw5MjSLsYJe3iJH99nYI= =0yR/ -----END PGP SIGNATURE----- --h31gzZEtNLTqOjlF--