From owner-svn-src-head@FreeBSD.ORG Mon Oct 29 14:37:42 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 590F1AAE; Mon, 29 Oct 2012 14:37:42 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-lb0-f182.google.com (mail-lb0-f182.google.com [209.85.217.182]) by mx1.freebsd.org (Postfix) with ESMTP id 3B24C8FC0C; Mon, 29 Oct 2012 14:37:40 +0000 (UTC) Received: by mail-lb0-f182.google.com with SMTP id b5so3963872lbd.13 for ; Mon, 29 Oct 2012 07:37:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=pbl2Fo3RPlUuLqXj9NLjgbCkwjTEioQwQvDNtGCYL8s=; b=0DlDmlj4jArUDWwwTh/7GJV1r5gYsgCksLiRD0komI6WK5g5foVcIzf40iXxR8l6/l SfST7s2uGKSHp5NGiTX4R36hcMhLIsw8ZxQ0Sr0MtDx+w56i97PaN9xi1+8ndPe7vRRR 3zdIJCYBemMP2aQi6wVNPzX85pzOZ3i3JBcq8fYFG8ASrIK/BaeK0RTg+TNk8wonKa1e PXzumSE3ZX08akbpriznQtzU/l31mV8RHtoE5eEDn/4nEkpkzsLjx/qCgS3ab6ElW0/R Fsm+Ptj14wE+60mGufSQvL8QIVEWhsHA4w5echPrdnPNuHI8hCxBgd5bDiuIbKvBECrk rkHQ== Received: by 10.152.108.42 with SMTP id hh10mr27147556lab.4.1351521458593; Mon, 29 Oct 2012 07:37:38 -0700 (PDT) Received: from mavbook.mavhome.dp.ua (mavhome.mavhome.dp.ua. [213.227.240.37]) by mx.google.com with ESMTPS id nr2sm3180495lab.5.2012.10.29.07.37.37 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 29 Oct 2012 07:37:38 -0700 (PDT) Sender: Alexander Motin Message-ID: <508E94B0.1040101@FreeBSD.org> Date: Mon, 29 Oct 2012 16:37:36 +0200 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:13.0) Gecko/20120628 Thunderbird/13.0.1 MIME-Version: 1.0 To: Andriy Gapon Subject: Re: svn commit: r242314 - head/sys/geom/raid References: <201210291418.q9TEIsrZ078107@svn.freebsd.org> <508E925C.3010707@FreeBSD.org> In-Reply-To: <508E925C.3010707@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2012 14:37:42 -0000 On 29.10.2012 16:27, Andriy Gapon wrote: > on 29/10/2012 16:18 Alexander Motin said the following: >> Author: mav >> Date: Mon Oct 29 14:18:54 2012 >> New Revision: 242314 >> URL: http://svn.freebsd.org/changeset/base/242314 >> >> Log: >> Make GEOM RAID more aggressive in marking volumes as clean on shutdown >> and move that action from shutdown_pre_sync to shutdown_post_sync stage >> to avoid extra flapping. >> >> ZFS tends to not close devices on shutdown, that doesn't allow GEOM RAID >> to shutdown gracefully. To handle that, mark volume as clean just when >> shutdown time comes and there are no active writes. > > Perhaps something like what zfs_modevent(MOD_UNLOAD) does should also be done in > one of the shutdown hooks? May be, but I don't know ZFS very good. > Maybe at the start of shutdown_post_sync (so that it is run before the hooks of > lower level drivers like graid)? graid would be happy if device would be closed at any point of time, either before or after. But before is preferable to avoid some flapping between dirtying and added here cleaning. -- Alexander Motin