Date: Mon, 29 Oct 2012 16:37:36 +0200 From: Alexander Motin <mav@FreeBSD.org> To: Andriy Gapon <avg@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r242314 - head/sys/geom/raid Message-ID: <508E94B0.1040101@FreeBSD.org> In-Reply-To: <508E925C.3010707@FreeBSD.org> References: <201210291418.q9TEIsrZ078107@svn.freebsd.org> <508E925C.3010707@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 29.10.2012 16:27, Andriy Gapon wrote: > on 29/10/2012 16:18 Alexander Motin said the following: >> Author: mav >> Date: Mon Oct 29 14:18:54 2012 >> New Revision: 242314 >> URL: http://svn.freebsd.org/changeset/base/242314 >> >> Log: >> Make GEOM RAID more aggressive in marking volumes as clean on shutdown >> and move that action from shutdown_pre_sync to shutdown_post_sync stage >> to avoid extra flapping. >> >> ZFS tends to not close devices on shutdown, that doesn't allow GEOM RAID >> to shutdown gracefully. To handle that, mark volume as clean just when >> shutdown time comes and there are no active writes. > > Perhaps something like what zfs_modevent(MOD_UNLOAD) does should also be done in > one of the shutdown hooks? May be, but I don't know ZFS very good. > Maybe at the start of shutdown_post_sync (so that it is run before the hooks of > lower level drivers like graid)? graid would be happy if device would be closed at any point of time, either before or after. But before is preferable to avoid some flapping between dirtying and added here cleaning. -- Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?508E94B0.1040101>