Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 1 Mar 2001 22:35:00 +0100 (CET)
From:      Martin Blapp <mb@imp.ch>
To:        Jonathan Lemon <jlemon@flugsvamp.com>
Cc:        Thomas Moestl <tmoestl@gmx.net>, current@freebsd.org
Subject:   Re: linux_connect patch
Message-ID:  <Pine.BSF.4.21.0103012232090.49300-100000@levais.imp.ch>
In-Reply-To: <20010227224908.K20550@prism.flugsvamp.com>

next in thread | previous in thread | raw e-mail | index | archive | help

Hi Jonathan,

I tested yout patch with CURRENT and STABLE, and it does
fix the Staroffice Network-Problem too.

I tested:

Linux SO5.2
Linux Netscape 4.7
Linux linux-jdk1.3.0, green threads (digichat)

and everythings works. So please commit this,
and it should also go into STABLE before 4.3
is out. This fix is really necessary.

Martin

> +	/*
> +	 * Linux doesn't return EISCONN the first time it occurs,
> +	 * when on a non-blocking socket. Instead it returns the
> +	 * error getsockopt(SOL_SOCKET, SO_ERROR) would return on BSD.
> +	 */
> +	error = holdsock(p->p_fd, linux_args.s, &fp);
> +	if (error)
> +		return (error);
> +	error = EISCONN;
> +	if (fp->f_flag & FNONBLOCK) {
> +		so = (struct socket *)fp->f_data;
> +		if ((u_int)so->so_emuldata != 0)
> +			error = so->so_error;
> +		so->so_emuldata = (void *)1;
>  	}
> -
> +	fdrop(fp, p);
>  	return (error);
>  }
>  
> 


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0103012232090.49300-100000>