From owner-svn-ports-head@FreeBSD.ORG Thu Aug 21 22:06:22 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8CEE7C26; Thu, 21 Aug 2014 22:06:22 +0000 (UTC) Received: from h.highsecure.ru (mail6.highsecure.ru [IPv6:2a01:4f8:191:22a6::99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4F0313C92; Thu, 21 Aug 2014 22:06:22 +0000 (UTC) Received: from [172.24.172.195] (global-2-11.nat.csx.cam.ac.uk [131.111.185.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: vsevolod@highsecure.ru) by h.highsecure.ru (Postfix) with ESMTPSA id 6227A300033; Fri, 22 Aug 2014 00:06:03 +0200 (CEST) Message-ID: <53F66D58.6040702@FreeBSD.org> Date: Thu, 21 Aug 2014 23:06:16 +0100 From: Vsevolod Stakhov User-Agent: Mutt/1.5.22 (2013-10-16) MIME-Version: 1.0 To: Matthias Andree , ports-committers@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r365596 - head/math/gringo/files References: <201408212040.s7LKeqJ0075659@svn.freebsd.org> <53F65A20.8070806@FreeBSD.org> <53F66B12.6040404@FreeBSD.org> In-Reply-To: <53F66B12.6040404@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Aug 2014 22:06:22 -0000 On 21.08.2014 22:56, Matthias Andree wrote: > Am 21.08.2014 um 22:44 schrieb Matthias Andree: >> Am 21.08.2014 um 22:40 schrieb Matthias Andree: >>> Author: mandree >>> Date: Thu Aug 21 20:40:52 2014 >>> New Revision: 365596 >>> URL: http://svnweb.freebsd.org/changeset/ports/365596 >>> QAT: https://qat.redports.org/buildarchive/r365596/ >>> >>> Log: >>> Test fix for math/gringo. >>> >>> Added: >>> head/math/gringo/files/ >>> head/math/gringo/files/patch-libprogram_opts__src__string_convert.cpp (contents, props changed) >>> >>> Added: head/math/gringo/files/patch-libprogram_opts__src__string_convert.cpp >>> ============================================================================== >>> --- /dev/null 00:00:00 1970 (empty, because file is newly added) >>> +++ head/math/gringo/files/patch-libprogram_opts__src__string_convert.cpp Thu Aug 21 20:40:52 2014 (r365596) >>> @@ -0,0 +1,12 @@ >>> +--- ./libprogram_opts/src/string_convert.cpp.orig 2014-08-12 17:47:21.000000000 +0200 >>> ++++ ./libprogram_opts/src/string_convert.cpp 2014-08-21 22:39:08.000000000 +0200 >>> +@@ -28,6 +28,9 @@ >>> + } >>> + #endif >>> + #endif >>> ++namespace std { >>> ++ using ::strtoull; >>> ++} >>> + namespace bk_lib { >>> + >>> + static int detectBase(const char* x) { >>> >> >> Whoops, I meant to commit this to redports but ran the commit from the >> wrong working directory, so it hit the official ports tree. Sorry for >> that. I'll let redports do its job, and if there's anything wrong, >> revert, else I'll let it live. >> >> This is meant to fix >> http://package20.nyi.freebsd.org/data/91amd64-default-baseline/365523/logs/errors/gringo-4.4.0_1.log >> > > The fix above works on 9.x, but not on 8.4 (per redports), but I cannot > seem to figure out why strtoull() does not get exposed there. I might > try forcing __BSD_SOURCE or other tricks on the source, but the > turnaround time on redports is prohibitive (> 20 min) and I no longer > have 8.x systems around nor would I care to install a new VM for that. > > As I'm not using the port actively, I'll leave it fixed on 9.x for now > with the commit above, but leave it to Vsevolod as maintainer, or > volunteers, to fix this on 8.x, too. > According to http://en.cppreference.com/w/cpp/string/byte/strtoul, std::strtoull is c++11 option. Hence, this port likely requires to use compiler:c++11-lib as well. I'll check this assumption tomorrow. -- Vsevolod Stakhov