Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 13 Aug 2020 22:07:21 +0000
From:      bugzilla-noreply@freebsd.org
To:        testing@FreeBSD.org
Subject:   [Bug 244168] sys.net.if_lagg_test.lacp_linkstate_destroy_stress panics kernel
Message-ID:  <bug-244168-32464-eIA9Px46aj@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-244168-32464@https.bugs.freebsd.org/bugzilla/>
References:  <bug-244168-32464@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D244168

--- Comment #6 from commit-hook@FreeBSD.org ---
A commit references this bug:

Author: bdrewery
Date: Thu Aug 13 22:06:27 UTC 2020
New revision: 364220
URL: https://svnweb.freebsd.org/changeset/base/364220

Log:
  lagg: Avoid adding a port to a lagg device being destroyed.

  The lagg_clone_destroy() handles detach and waiting for ifconfig callers
  to drain already.

  This narrows the race for 2 panics that the tests triggered. Both were a
  consequence of adding a port to the lagg device after it had already deta=
ched
  from all of its ports. The link state task would run after
lagg_clone_destroy()
  free'd the lagg softc.

      kernel:trap_fatal+0xa4
      kernel:trap_pfault+0x61
      kernel:trap+0x316
      kernel:witness_checkorder+0x6d
      kernel:_sx_xlock+0x72
      if_lagg.ko:lagg_port_state+0x3b
      kernel:if_down+0x144
      kernel:if_detach+0x659
      if_tap.ko:tap_destroy+0x46
      kernel:if_clone_destroyif+0x1b7
      kernel:if_clone_destroy+0x8d
      kernel:ifioctl+0x29c
      kernel:kern_ioctl+0x2bd
      kernel:sys_ioctl+0x16d
      kernel:amd64_syscall+0x337

      kernel:trap_fatal+0xa4
      kernel:trap_pfault+0x61
      kernel:trap+0x316
      kernel:witness_checkorder+0x6d
      kernel:_sx_xlock+0x72
      if_lagg.ko:lagg_port_state+0x3b
      kernel:do_link_state_change+0x9b
      kernel:taskqueue_run_locked+0x10b
      kernel:taskqueue_run+0x49
      kernel:ithread_loop+0x19c
      kernel:fork_exit+0x83

  PR:           244168
  Reviewed by:  markj
  MFC after:    2 weeks
  Sponsored by: Dell EMC
  Differential Revision:        https://reviews.freebsd.org/D25284

Changes:
  head/sys/net/if_lagg.c

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-244168-32464-eIA9Px46aj>