From owner-dev-commits-src-all@freebsd.org Sat Jul 31 18:08:19 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5025C6624AE for ; Sat, 31 Jul 2021 18:08:19 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x729.google.com (mail-qk1-x729.google.com [IPv6:2607:f8b0:4864:20::729]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GcXLp2RFzz4pCJ for ; Sat, 31 Jul 2021 18:08:18 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x729.google.com with SMTP id t66so12798330qkb.0 for ; Sat, 31 Jul 2021 11:08:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=X3LmiCM4sHpwWMFEZobq0F67XDchpsF8RWPfdPhJ9fg=; b=piwCWbI+A63tVsHgYAQP/eKD0jDEkEfXv5e7DXVoYOUSmuwlPmJztocDRnizW0c4k2 VDTb85LAnlRti3/eBnzL2j+vU+AFiNjIdvXtLcfZcJEG8vconqrip9jYvW9Je6b14GXF 1t5ORtUrbjIz/sucSqpeyb+iAvy+dEavHzq511/9334mX6MBn0k3jeVkgbR0mJ3sCnj/ bWOk2JcrLcwgfWiuv4lE8FN8VW4d7kpP+c2RR6PlB7vhljXgEMQvOEXHUwvDucvamJwb BUK7MHvG1wtJOLbUyfjrEclv/nnwDigL4WFwFjwVNydjStzIsrwPxzGJEfY7qOhuUtdD wmEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X3LmiCM4sHpwWMFEZobq0F67XDchpsF8RWPfdPhJ9fg=; b=MwHGTQCI9a9nflxkArN0pwoVVSbKn1UUwPEI4kK6uzEhZSfzPD758masbkdyamcPiA nPciEDgeuKsS1VIaV7dZ5IrJ7tnFa17A5CvMgM39aLMTmntpqcW5osIkkg7YBQszcazw ZBK1MI0jyUjQIPmYtjwNf9XfrPiZfL0KdukUNHPbfpNQTrRBgseb2owbr//icd7+e335 Q4LKMZqkt5+n6l/1nGMTbb0oEIsyxaum5NCx1gFTegd/ZLdDkjsiGT3MRFZJ0o700Upx i0cc5INz7wIoIPJxXgA8fP8goFzBvvda+IX6vm0PdJdHNMWsY15Yy83jUNdp01AI5CPl TcVw== X-Gm-Message-State: AOAM530gMhcjn4m+gNfbxfN7mDH9SyED0aJI2YcgHrApxQVs1LTQQXOm qKc/XWDpYx/FIyolonMQJpALHjqnmHCilHUSuSI04A== X-Google-Smtp-Source: ABdhPJyG+p5RGwkOt9CeYKjYu/Ceejo6vjTaPNHa0CzthB39Q2VGRjjm1V3/pNCTjMiW9Q/iO9ELlmz4yU326RzTzxE= X-Received: by 2002:a05:620a:5f6:: with SMTP id z22mr7962507qkg.195.1627754892042; Sat, 31 Jul 2021 11:08:12 -0700 (PDT) MIME-Version: 1.0 References: <202107101712.16AHCwoE088447@gitrepo.freebsd.org> <4AD3AB8C-A960-43BE-A89B-5D9C4CD077DD@FreeBSD.org> <8300183E-DD11-4C2F-AE5A-0B6FDE6E9E8F@FreeBSD.org> In-Reply-To: From: Warner Losh Date: Sat, 31 Jul 2021 12:08:01 -0600 Message-ID: Subject: Re: git: 6edf5082bab7 - stable/12 - one-true-awk: import 20210221 (1e4bc42c53a1) which fixes a number of bugs To: Kristof Provost Cc: Warner Losh , src-committers , "" , dev-commits-src-branches@freebsd.org X-Rspamd-Queue-Id: 4GcXLp2RFzz4pCJ X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=piwCWbI+; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::729) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-3.00 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-1.00)[-0.997]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::729:from]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; MAILMAN_DEST(0.00)[dev-commits-src-all]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Jul 2021 18:08:19 -0000 On Sat, Jul 31, 2021 at 11:28 AM Warner Losh wrote: > > > On Sat, Jul 31, 2021 at 9:37 AM Kristof Provost wrote: > >> On 31 Jul 2021, at 16:20, Warner Losh wrote: >> > On Sat, Jul 31, 2021 at 8:07 AM Warner Losh wrote: >> > >> >> >> >> >> >> On Sat, Jul 31, 2021 at 3:11 AM Kristof Provost >> >> wrote: >> >> >> >>> Hi Warner, >> >>> >> >>> On 10 Jul 2021, at 19:12, Warner Losh wrote: >> >>> >> >>> The branch stable/12 has been updated by imp: >> >>> >> >>> URL: >> >>> >> https://cgit.FreeBSD.org/src/commit/?id=3D6edf5082bab71cf923efff9f18e38e= fe5b83b0ec >> >>> >> >>> commit 6edf5082bab71cf923efff9f18e38efe5b83b0ec >> >>> Author: Warner Losh >> >>> AuthorDate: 2021-07-07 23:30:35 +0000 >> >>> Commit: Warner Losh >> >>> CommitDate: 2021-07-10 17:11:15 +0000 >> >>> >> >>> one-true-awk: import 20210221 (1e4bc42c53a1) which fixes a number of >> >>> bugs >> >>> >> >>> Import the latest bsd-features branch of the one-true-awk upstream: >> >>> >> >>> o Move to bison for $YACC >> >>> o Set close-on-exec flag for file and pipe redirects that aren't >> >>> std* >> >>> o lots of little fixes to modernize ocde base >> >>> o free sval member before setting it >> >>> o fix a bug where a{0,3} could match aaaa >> >>> o pull in systime and strftime from NetBSD awk >> >>> o pull in fixes from {Net,Free,Open}BSD (normalized our code with >> >>> them) >> >>> o add BSD extensions and, or, xor, compl, lsheift, rshift (mostly a >> >>> nop) >> >>> >> >>> Also revert a few of the trivial FreeBSD changes that were done >> >>> slightly >> >>> differently in the upstreaming process. Also, our PR database may >> >>> have >> >>> been mined by upstream for these fixes, and Mikolaj Golub may >> >>> deserve >> >>> credit for some of the fixes in this update. >> >>> >> >>> Suggested by: Mikolaj Golub >> >>> PR: 143363,143365,143368,143369,143373,143375,214782 >> >>> Sponsored by: Netflix >> >>> >> >>> (cherry picked from commit f39dd6a9784467f0db5886012b3f4b13899be6b8) >> >>> >> >>> I *think* this is the relevant commit, but I=E2=80=99m not 100% sure= . >> >>> >> >>> Anyway, I=E2=80=99ve recently started seeing issues building pfSense= for >> >>> aarch64. >> >>> I=E2=80=99ve finally narrowed it down, and replicated the problem on= base >> >>> FreeBSD >> >>> (stable/12, but I assume other branches are affected too). >> >>> >> >>> It fails to build proctab.c. This file is generated by maketab, a >> >>> tool >> >>> built as part of the build process. In my case this tool is built >> >>> for >> >>> aarch64, which makes executing it on amd64 less successful than >> >>> we=E2=80=99d like. >> >>> >> >>> This only happens when building with META_MODE though. I do not >> >>> understand the build system sufficiently to debug why. Hopefully >> >>> you=E2=80=99ll >> >>> have a better idea. >> >>> >> >> Generally I do, but this one is a bit weird. Also, the amount of >> >> context >> >> you've included omits the actual error :( Though I'm guessing it's >> >> wrong >> >> arch for the build tool... >> >> >> >> I rarely use meta mode, and understand it not at all, but awk follows >> >> the >> >> same patterns as /bin/sh and /bin/csh does >> >> >> > >> > [[ stupid gmail ]] >> > >> > I've just pushed removal of proctab.c. That may fix this, though I'm >> > not >> > hopeful. >> Unfortunately that didn=E2=80=99t help. >> >> > I've rarely used metamode, and not for quite some time, but this >> > an extra file that would confuse things so that maketab might not be >> > built >> > during build-tools and instead is built later. Please give that a try, >> > and >> > I'll start a meta build, but that takes a while, not least because I >> > have >> > to re-leran how to do that :) >> > >> I=E2=80=99ve posted my build log and the proctab.c.meta and maketab.meta= files >> on https://people.freebsd.org/~kp/meta/ >> >> I=E2=80=99m a little confused by maketab.meta, because what=E2=80=99s in= the meta >> file doesn=E2=80=99t seem to match the build command seen in the metamod= e.log >> file. >> > > Yea. It's getting confused and rebuilding it bogusly. For the mknodes in > sh, we don't see the naked cc command, but we do for maketab. > > I'm testing a fix right now, though, and we'll see if that fixes things. = I > think I know what's going on. > I just pushed 1dfb6e5d1f462af4f4df818ee93766f09f3aa787, which fixed the issues I was seeing. Does that do the trick for you as well? Warner