From owner-freebsd-current@FreeBSD.ORG Wed Jan 23 21:29:28 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 1F822C13; Wed, 23 Jan 2013 21:29:28 +0000 (UTC) (envelope-from gibbs@freebsd.org) Received: from aslan.scsiguy.com (mail.scsiguy.com [70.89.174.89]) by mx1.freebsd.org (Postfix) with ESMTP id CD48DC7; Wed, 23 Jan 2013 21:29:27 +0000 (UTC) Received: from benscottlt.sldomain.com (207-225-98-3.dia.static.qwest.net [207.225.98.3]) (authenticated bits=0) by aslan.scsiguy.com (8.14.5/8.14.5) with ESMTP id r0NLT2De001731 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Wed, 23 Jan 2013 14:29:26 -0700 (MST) (envelope-from gibbs@freebsd.org) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 6.2 \(1499\)) Subject: Re: panic after r244584 From: "Justin T. Gibbs" In-Reply-To: <51004A69.6020809@FreeBSD.org> Date: Wed, 23 Jan 2013 14:29:28 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20130118094424.GD2331@FreeBSD.org> <50F93165.60809@FreeBSD.org> <20130118113934.GA60441@hell.ukr.net> <50F9357F.8040109@FreeBSD.org> <20130118131954.GA3868@a91-153-116-96.elisa-laajakaista.fi> <50F94D80.7000809@FreeBSD.org> <20130119082739.GA1956@a91-153-116-96.elisa-laajakaista.fi> <20130121154400.GA1808@a91-153-116-96.elisa-laajakaista.fi> <20130121173122.GA20466@hell.ukr.net> <20130123071346.GA56937@hell.ukr.net> <20130123195104.GA1802@a91-153-116-96.elisa-laajakaista.fi> <51004A69.6020809@FreeBSD.org> To: Alexander Motin X-Mailer: Apple Mail (2.1499) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (aslan.scsiguy.com [70.89.174.89]); Wed, 23 Jan 2013 14:29:27 -0700 (MST) Cc: Jaakko Heinonen , Gleb Smirnoff , freebsd-current@freebsd.org, Vitalij Satanivskij X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jan 2013 21:29:28 -0000 On Jan 23, 2013, at 1:39 PM, Alexander Motin wrote: > On 23.01.2013 21:51, Jaakko Heinonen wrote: >> On 2013-01-23, Vitalij Satanivskij wrote: >>> VS> Jaakko Heinonen wrote: >>> VS> JH> > I see two possible solutions for the problem. >>> VS> JH> >=20 >>> VS> JH> > 1) Replace non-printable, space and '/' characters for = example with '_'. >>> VS> JH> > '/' should be replaced anyway. >>> VS> JH> >=20 >>> VS> JH> > 2) Apply the patches in >>> VS> JH> > = http://lists.freebsd.org/pipermail/svn-src-all/2013-January/063661.html >>> VS> JH> > to allow spaces again. I haven't committed the patches = because I >>> VS> JH> > think that there isn't full consensus that it's right = thing to do and >>> VS> JH> > also I personally prefer not to have spaces in device = names. >>> VS> JH>=20 >>> VS> JH> Here's a patch to implement 1: >>> VS> JH>=20 >>> VS> JH> = http://people.freebsd.org/~jh/patches/scsi_enc_ses-si_name.diff >>> VS>=20 >>> VS> Ok that patch work's too. >>>=20 >>> Is there any chance, that one of this patches will be merged to = head?=20 >>=20 >> Yes. >>=20 >> Alexander and Justin: what do you think about this patch? >>=20 >> http://people.freebsd.org/~jh/patches/scsi_enc_ses-si_name.diff >=20 > It is fine for me, or at least better then panic. But that is Justin's > code, so he should know better. It's fine. -- Justin