From owner-freebsd-current@freebsd.org Sat Dec 21 21:18:46 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 81EC21DD012 for ; Sat, 21 Dec 2019 21:18:46 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 47gJPy1jHTz4dxJ for ; Sat, 21 Dec 2019 21:18:46 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: by mailman.nyi.freebsd.org (Postfix) id 3A86D1DD011; Sat, 21 Dec 2019 21:18:46 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3A4FC1DD00F for ; Sat, 21 Dec 2019 21:18:46 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 47gJPx1QkDz4dxH for ; Sat, 21 Dec 2019 21:18:44 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id im92iPMg2kqGXim94iegrK; Sat, 21 Dec 2019 14:18:43 -0700 X-Authority-Analysis: v=2.3 cv=c/jVvi1l c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=pxVhFHJ0LMsA:10 a=ndaoGXS1AAAA:8 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=ZO0UrhebNd9ci4EYASwA:9 a=CjuIK1q_8ugA:10 a=mFeOnlTyF09QQMGr2mMI:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 2DDDD154; Sat, 21 Dec 2019 13:18:40 -0800 (PST) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id xBLLIdwZ053761; Sat, 21 Dec 2019 13:18:39 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id xBLLIbJF053713; Sat, 21 Dec 2019 13:18:38 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201912212118.xBLLIbJF053713@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Jeff Roberson cc: Hans Petter Selasky , Cy Schubert , current@freebsd.org Subject: Re: drm-current-kmod panics In-reply-to: References: <201912191650.xBJGotp2003261@slippy.cwsent.com> <201912191840.xBJIeqQX071052@slippy.cwsent.com> Comments: In-reply-to Jeff Roberson message dated "Thu, 19 Dec 2019 09:20:32 -1000." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sat, 21 Dec 2019 13:18:37 -0800 X-CMAE-Envelope: MS4wfFWTBpklIvjdIF5iYRn2dQSwpEZ0ug4b8TQ1rTzji5cj97QDEMvS32aewDTAj0fBoVqpzHVgKsQjSZg4KPC+Vg7Rr0/8atyvWEsy/8iOnKiNnsdPF3LD nCDfQEzC90+9WTfcMJ3/md3y8HUxxRtdiyCQ8mwCvu8heQYCy8HHiDM/6pC9R/w9sRdn1fZxufygqmm2gFo3VyUv9VLzeyzvDnMPavD3OT7w3WwjBJmOKHdE sRx/AuYsvOcBuiN8leOLoA== X-Rspamd-Queue-Id: 47gJPx1QkDz4dxH X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; spf=none (mx1.freebsd.org: domain of cy.schubert@cschubert.com has no SPF policy when checking 64.59.134.13) smtp.mailfrom=cy.schubert@cschubert.com X-Spamd-Result: default: False [-4.11 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLYTO_EQ_FROM(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[13.134.59.64.rep.mailspike.net : 127.0.0.17]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RECEIVED_SPAMHAUS_PBL(0.00)[17.125.67.70.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.11]; R_SPF_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; RCVD_IN_DNSWL_LOW(-0.10)[13.134.59.64.list.dnswl.org : 127.0.5.1]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; RCVD_TLS_LAST(0.00)[]; IP_SCORE(-2.41)[ip: (-6.46), ipnet: 64.59.128.0/20(-3.09), asn: 6327(-2.40), country: CA(-0.09)]; FROM_EQ_ENVFROM(0.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Dec 2019 21:18:46 -0000 In message , Jeff Roberson wri tes: > On Thu, 19 Dec 2019, Hans Petter Selasky wrote: > > > On 2019-12-19 19:40, Cy Schubert wrote: > >> In message , Hans Petter > >> Sela > >> sky writes: > >>> On 2019-12-19 17:50, Cy Schubert wrote: > >>>> Has anyone else had these since Dec 9? > >>>> > >>>> <4>WARN_ON(!mutex_is_locked(&fbc->lock))WARN_ON(!mutex_is_locked(&fbc-> > >>>> lock)) > >>>> panic: page fault > >>>> cpuid = 1 > >>>> time = 1576772837 > >>>> KDB: stack backtrace: > >>>> db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame > >>>> 0xfffffe007c98b930 > >>>> vpanic() at vpanic+0x17e/frame 0xfffffe007c98b990 > >>>> panic() at panic+0x43/frame 0xfffffe007c98b9f0 > >>>> trap_fatal() at trap_fatal+0x386/frame 0xfffffe007c98ba50 > >>>> trap_pfault() at trap_pfault+0x4f/frame 0xfffffe007c98bac0 > >>>> trap() at trap+0x41b/frame 0xfffffe007c98bbf0 > >>>> calltrap() at calltrap+0x8/frame 0xfffffe007c98bbf0 > >>>> --- trap 0xc, rip = 0x242c52, rsp = 0x7fffffffbe70, rbp = 0x7fffffffbe90 > > >>>> -- > >>> - > >>>> Uptime: 59m7s > >>>> > >>>> It is triggered through random keystrokes or mouse movements. > >>> > >>> Looks like a double fault. > >>> > >>> Did you recompile drm-current-kmod with the latest kernel sources? > >> > >> Yes. > >> > >> > > > > Are you able to get a full backtrace? > > Since my recent scheduler commits the following functions now return > without the thread lock held: > > sched_add()/sched_wakeup()/sched_switch()/mi_switch()/setrunnable()/sleepq_ab > ort() > > I audited drm and linuxkpi for use of these functions. There was one in > the linuxkpi sources that I corrected in the same commit as the change in > api. I don't see any users of these in drm-current-kmod. It is possible > that I have somehow missed it. I did just commit a fix to cpuset that may > be called indirectly somehow. That fix is r355915. The first commit of > this series was r35579. > > If this is at fault I may need some assistance in identifying what the > offending call is. It should show up with INVARIANTS/WITNESS more quickly > than a pagefault if so though. I haven't had any new drm-current-kmod panics since r355915. It's been solid. Thank you Jeff. > > Thanks, > Jeff -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.