From owner-freebsd-ports@FreeBSD.ORG Wed Aug 3 04:05:20 2011 Return-Path: Delivered-To: ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4B735106564A; Wed, 3 Aug 2011 04:05:20 +0000 (UTC) (envelope-from sahil@tandon.net) Received: from spartan.hamla.org (spartan.hamla.org [206.251.255.30]) by mx1.freebsd.org (Postfix) with ESMTP id 1F0998FC0A; Wed, 3 Aug 2011 04:05:20 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by spartan.hamla.org (Postfix) with ESMTP id AC1DE1711F; Wed, 3 Aug 2011 00:05:48 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tandon.net; h= user-agent:in-reply-to:content-disposition:content-type :content-type:mime-version:references:reply-to:message-id :subject:subject:from:from:date:date:received; s=aegis; t= 1312344348; bh=lAHouJBJLHlulVMHJU9u4adwN++qwISefyHM3Zs19ao=; b=K Ekky9o4Kg6Uqj36OD074vT3BPDkzSgPJhxfIsNsxC0yMBiagPGwpfBfxX7A7Yxoh E6qUbNGbKx/t983nIbvFudyWxm/jc46E4bINeCePtjHAlPWy+tjG/MVUUy2cR1v4 TEB0kcxAbMDcCSr890c7JO8wJTbUMr1sDsEwyjHVwM= X-Virus-Scanned: by ClamAV at spartan.hamla.org Received: from spartan.hamla.org ([127.0.0.1]) by localhost (spartan.hamla.org [127.0.0.1]) (amavisd-new, port 10027) with LMTP id wIdIPVti8v72; Wed, 3 Aug 2011 00:05:48 -0400 (EDT) Date: Wed, 3 Aug 2011 00:05:16 -0400 From: Sahil Tandon To: Miroslav Lachman <000.fbsd@quip.cz> Message-ID: <20110803040516.GD1447@magic.hamla.org> References: <4E368625.7010805@quip.cz> <4E370ADA.9060902@FreeBSD.org> <4E371284.5010806@quip.cz> <4E371B3B.7070806@FreeBSD.org> <4E3722DE.6050206@gmx.de> <20110802010139.GA981@magic.hamla.org> <4E37F71D.7070502@quip.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4E37F71D.7070502@quip.cz> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: ports@FreeBSD.org, ohauer@FreeBSD.org, portmgr@FreeBSD.org Subject: Re: USERS/GROUPS in bsd.port.mk [was: FreeBSD Port: postfix-2.8.4,1] X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Sahil Tandon List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Aug 2011 04:05:20 -0000 [ adding portmgr@ to the chain since we're in bpmk territory] On Tue, 2011-08-02 at 15:09:49 +0200, Miroslav Lachman wrote: > Sahil Tandon wrote: > >On Tue, 2011-08-02 at 00:04:14 +0200, olli hauer wrote: > > > >>No, you don't hit the limitation. It seems you really found a bug in > >>the Framework! > >> > >> From the Framework code in bsd.port.mk existing groups should honored. > > > >Along those lines, what about using groupmod instead of usermod? > >Perhaps due to my ignorance, it seems more straightforward and does not > >require much sed-fu; I've attached a (probably incomplete) patch to > >illustrate my thinking. I understand what I am suggesting could > >introduce other problems, so please do not construe it as an as-is > >suggestion, but rather something to stoke discussion. > > I tested your patch and it works for me. [ .. ] > It was tested on really old testing system... > > Thank you for your time and working solution. You are welcome - thanks again for reporting the problem and testing the new patch. I believe ohauer@ is taking a look at how else to achieve the desired behavior without introducing new problems. I hope we can get a fix into the tree soon. -- Sahil Tandon