From owner-svn-src-all@freebsd.org Fri Aug 19 04:15:14 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E9D30BBD2F5 for ; Fri, 19 Aug 2016 04:15:14 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ua0-x236.google.com (mail-ua0-x236.google.com [IPv6:2607:f8b0:400c:c08::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9DA6D113B for ; Fri, 19 Aug 2016 04:15:14 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-ua0-x236.google.com with SMTP id 74so61670538uau.0 for ; Thu, 18 Aug 2016 21:15:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=iQ3YGGCdF+pAGNH7dNeoOcCqy3PJOVkUhFdPBrtmodQ=; b=OOfvKdy8ZCLij1L0Di5HwXqkCVfAl158iiokVGIPgKKeWLF4d1gtobCzrA4TUigrn8 i/tBDG0SGWB2y2/1PUtREubMPdGcGHCR+NQcuDQ6XGWC3opNWXRgJPYbw6X+cb0857ln UCVl3y5Tyqo9XqPkd4Gl9SKRmAu25fvsgdugKzNmv6Ja7B3rGrIUVf7PFFCPuCQ8b/sK R+oJ9slMeErvuTbjLQxjRbWKWoH5LL/VF11YjCDIK3rIhuhfSLV/A784bWC5oOYXeUfq LTPesbF0xeYB5cO5qxUzM01a+LIR+isC+UZnM8Gs3qiWrBFGlU276Gtluw9+WT6vxkJ+ pDzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=iQ3YGGCdF+pAGNH7dNeoOcCqy3PJOVkUhFdPBrtmodQ=; b=V3lDeOJgkcRIvvKG6dhAVeZAwgjlt0vD3aUGLfn/N57HFyT4/l5dUAEkCp4PVQNPCj fgpKsvv9F6shu88qfUqXcKhEOrzsIEVdItxtN9acWgPPYi7wLTiv1VSC+bQ15o948u7j wHSiCgxlG3g43A5QyDj+TAevfyVJlP+f6VoqrC1RsnTNLN2xg3eN13XBTlLCHpomt6xE 6JO1NG4EX+otiJhpiYaIQZHxTM2Il1wHNirQXn8l5c9Nbkh0FglCbjI49OWcni6P7eJM 9bMs1ajeBCTSs6VkSjvDhUB3J2btAAIaQ1DbfFJrvlUjuXQpyxq1Hr6dwUz4C5BFKDgO W9lQ== X-Gm-Message-State: AEkoouv/T8TyOKeXaxqxOpC+1B2kHCSD9RPMRg/HZShhar4F9YlUEPntGVXF8I41NvcsyoCc6UHdzbbXUX1MVw== X-Received: by 10.176.1.69 with SMTP id 63mr2635301uak.54.1471580113525; Thu, 18 Aug 2016 21:15:13 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.103.0.84 with HTTP; Thu, 18 Aug 2016 21:15:12 -0700 (PDT) X-Originating-IP: [69.53.245.200] In-Reply-To: <2f9fb04c-7ec4-be40-8fcb-0cf74bb56859@freebsd.org> References: <201608150930.u7F9UL1V069576@repo.freebsd.org> <861t1n6749.fsf@desk.des.no> <581c856c-826b-529e-c9c6-a397fb679708@freebsd.org> <86wpjf4eun.fsf@desk.des.no> <8cb3fa1a-50cb-e238-d006-b98a628d446d@freebsd.org> <86k2ff4cxs.fsf@desk.des.no> <86fuq24d8s.fsf@desk.des.no> <2f9fb04c-7ec4-be40-8fcb-0cf74bb56859@freebsd.org> From: Warner Losh Date: Thu, 18 Aug 2016 22:15:12 -0600 X-Google-Sender-Auth: EOoSBzZl5a8HyLOEO4kcFamTsuI Message-ID: Subject: Re: svn commit: r304142 - head/usr.sbin/bsdinstall/partedit To: Allan Jude Cc: =?UTF-8?Q?Dag=2DErling_Sm=C3=B8rgrav?= , Nathan Whitehorn , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Aug 2016 04:15:15 -0000 On Thu, Aug 18, 2016 at 6:56 AM, Allan Jude wrote: > On 08/18/16 05:50 AM, Dag-Erling Sm=C3=B8rgrav wrote: >> Nathan Whitehorn writes: >>> OK. In which configurations? My Dell servers, for instance, don't do >>> this. How are they set up? What drivers are being used? Is this >>> something that affects passthrough disks, RAIDs, disk images? >> >> Most LSI MegaRAID controllers don't have real passthrough, only JBOD. >> You can query the drive with "camcontrol identify passX", but the >> controller does not report a stripe size for the volume (mfidY). >> >>> The point is that *if the reported stripe size is wrong*, more things >>> than partition alignment in the installer will suffer for it. >> >> It's not wrong, it's non-existent, and I'm getting really tired of >> repeating myself. >> >>> Fixing the installer with a bandaid in the run-up to a release is >>> fine, but *we need to fix the underlying problem*. >> >> We can't, because hardware sucks, and I'm getting really tired of >> repeating myself. >> >> DES >> > > Which makes more sense: > > A) If stripesize =3D=3D 0, use some sane value like 4096 I don't like this. > B) Some other combination that uses the reported stripe size, unless it > is 0, in which case it uses 4096 (or some other value controlled by a > different new sysctl) Don't like this so much. > C) create kern.geom.min_stripe_size with a default of 512, but users can > set 4096 if they use only 4k devices. (doesn't really solve the problem > for the installer) Default it to 4k, and allow users to set it to 512. If the drive reports < this value report this value instead. You'll need to make this a tunable. Then the upp= er layers wouldn't care. There's a small chance that some SD cards might be reporting values that are too large. But I think it is confined to SD cards= and if I see too many more I'll do something specific in the SD driver. Warner