From owner-cvs-all@FreeBSD.ORG  Sat Feb  4 16:16:41 2006
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B675616A420
	for <cvs-all@FreeBSD.org>; Sat,  4 Feb 2006 16:16:41 +0000 (GMT)
	(envelope-from dougb@FreeBSD.org)
Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4])
	by mx1.FreeBSD.org (Postfix) with SMTP id 48A7D4464E
	for <cvs-all@FreeBSD.org>; Sat,  4 Feb 2006 16:16:40 +0000 (GMT)
	(envelope-from dougb@FreeBSD.org)
Received: (qmail 23462 invoked by uid 399); 1 Feb 2006 01:09:58 -0000
Received: from localhost (HELO ?192.168.0.3?) (dougb@dougbarton.us@127.0.0.1)
	by localhost with SMTP; 1 Feb 2006 01:09:58 -0000
Message-ID: <43E00A62.8090908@FreeBSD.org>
Date: Tue, 31 Jan 2006 17:09:54 -0800
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://www.FreeBSD.org/
User-Agent: Thunderbird 1.5 (X11/20060112)
MIME-Version: 1.0
To: Jun Kuriyama <kuriyama@FreeBSD.org>
References: <200601301402.k0UE2oKX097948@repoman.freebsd.org>
In-Reply-To: <200601301402.k0UE2oKX097948@repoman.freebsd.org>
X-Enigmail-Version: 0.94.0.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: cvs-ports@FreeBSD.org, Andrew Pantyukhin <infofarmer@gmail.com>,
	cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/comms/conserver-com Makefile distinfo
 pkg-plist
 ports/comms/conserver-com/files conserver.sh conserver.sh.in
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 04 Feb 2006 16:16:41 -0000

Jun Kuriyama wrote:
> kuriyama    2006-01-30 14:02:49 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     comms/conserver-com  Makefile distinfo pkg-plist 
>   Added files:
>     comms/conserver-com/files conserver.sh.in 
>   Removed files:
>     comms/conserver-com/files conserver.sh 
>   Log:
>   - Upgrade to 8.1.13.
>   - Improve $USE_RC_SUBR usage.

Overall this looks good, thanks! One nit though, it is no longer necessary
to include the FreeBSD KEYWORD, as rc.subr doesn't need it. On the other
hand, since I believe that this port is responsible for starting a daemon,
it should probably include 'REQUIRE: DAEMON', and the shutdown KEYWORD. I'd
be happy to make those changes if they are appropriate, just let me know.

Regards,

Doug


>   PR:             ports/91839  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=91839
>   Submitted by:   Andrew Pantyukhin <infofarmer@gmail.com>
>   
>   Revision  Changes    Path
>   1.30      +2 -11     ports/comms/conserver-com/Makefile
>   1.20      +3 -3      ports/comms/conserver-com/distinfo
>   1.3       +0 -22     ports/comms/conserver-com/files/conserver.sh (dead)
>   1.1       +22 -0     ports/comms/conserver-com/files/conserver.sh.in (new)
>   1.5       +0 -1      ports/comms/conserver-com/pkg-plist
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/comms/conserver-com/Makefile.diff?&r1=1.29&r2=1.30&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/comms/conserver-com/distinfo.diff?&r1=1.19&r2=1.20&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/comms/conserver-com/files/conserver.sh
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/comms/conserver-com/files/conserver.sh.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/comms/conserver-com/pkg-plist.diff?&r1=1.4&r2=1.5&f=h
> 


-- 

    This .signature sanitized for your protection