From owner-svn-src-head@freebsd.org  Fri Aug 17 15:29:00 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9C2FE10724F6;
 Fri, 17 Aug 2018 15:29:00 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org
 [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "smtp.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 3C39A837DF;
 Fri, 17 Aug 2018 15:29:00 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com
 [209.85.208.170])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G3" (verified OK))
 (Authenticated sender: kevans)
 by smtp.freebsd.org (Postfix) with ESMTPSA id C2821278E7;
 Fri, 17 Aug 2018 15:28:59 +0000 (UTC)
 (envelope-from kevans@freebsd.org)
Received: by mail-lj1-f170.google.com with SMTP id u7-v6so6691398lji.3;
 Fri, 17 Aug 2018 08:28:59 -0700 (PDT)
X-Gm-Message-State: AOUpUlFgqM1+jpFFDdMRwek8VRpGLDdt1TtF0Vr8pX04mDFpjAWsz/zL
 ozYx/1Apn6bDjC3EcEP40eSnggvcsZXt7WXA0t0=
X-Google-Smtp-Source: AA+uWPzyYcFx674KlBojF5aoynp06qROf2QCry3dg+GGz62h3NMOUGcZa/bbGluvf/DA5yrYsvBq3Fd1bk87lF5bKHo=
X-Received: by 2002:a2e:4055:: with SMTP id
 n82-v6mr22201257lja.99.1534519738281; 
 Fri, 17 Aug 2018 08:28:58 -0700 (PDT)
MIME-Version: 1.0
Received: by 2002:a2e:5742:0:0:0:0:0 with HTTP; Fri, 17 Aug 2018 08:28:37
 -0700 (PDT)
In-Reply-To: <CACNAnaEETxxJX-_S81cwe5R9TcpY6u8OaSdc7u8voLp+i09qBA@mail.gmail.com>
References: <201808170415.w7H4Fp7D046775@repo.freebsd.org>
 <201808171524.w7HFOdQi059798@pdx.rh.CN85.dnsmgr.net>
 <CACNAnaEETxxJX-_S81cwe5R9TcpY6u8OaSdc7u8voLp+i09qBA@mail.gmail.com>
From: Kyle Evans <kevans@freebsd.org>
Date: Fri, 17 Aug 2018 10:28:37 -0500
X-Gmail-Original-Message-ID: <CACNAnaHn+T27_LCvbVuUWZtjyVcgQEKOegmC=K3NEvyDiPi4NQ@mail.gmail.com>
Message-ID: <CACNAnaHn+T27_LCvbVuUWZtjyVcgQEKOegmC=K3NEvyDiPi4NQ@mail.gmail.com>
Subject: Re: svn commit: r337956 - in head: . bin/ls
To: Kyle Evans <kevans@freebsd.org>
Cc: "Rodney W. Grimes" <rgrimes@freebsd.org>,
 src-committers <src-committers@freebsd.org>, 
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Aug 2018 15:29:00 -0000

On Fri, Aug 17, 2018 at 10:26 AM, Kyle Evans <kevans@freebsd.org> wrote:
> On Fri, Aug 17, 2018 at 10:24 AM, Rodney W. Grimes
> <freebsd@pdx.rh.cn85.dnsmgr.net> wrote:
>> [ Charset UTF-8 unsupported, converting... ]
>>> Author: kevans
>>> Date: Fri Aug 17 04:15:51 2018
>>> New Revision: 337956
>>> URL: https://svnweb.freebsd.org/changeset/base/337956
>>>
>>> Log:
>>>   ls(1): Add --color=when
>>>
>>>   --color may be set to one of: 'auto', 'always', and 'never'.
>>>
>>>   'auto' is the default behavior- output colors only if -G or COLORTERM are
>>
>> Why different than coreutils ls?   Default for coreutils is none.
>
> I guess this was worded poorly and you skipped both the review and
> reading the diff... this is still contingent on environment variables
> or -G being specified.
>
>>>   set, and only if stdout is a tty.
>>>
>>>   'always' is a new behavior- output colors always. termcap(5) will be
>>>   consulted unless TERM is unset or not a recognized terminal, in which case
>>>   ls(1) will fall back to explicitly outputting ANSI escape sequences.
>>>
>>>   'never' to turn off any environment variable and -G usage.
>> Why different than core utils?  Coreutils uses none.
>
> I guess this was worded poorly and you skipped both the review and
> reading the diff... this is still contingent on environment variables
> or -G being specified.
>

... copy-paste-o. The version of coreutils ls(1) that I have uses
'never' for this. There is no valid 'none' value.