From owner-svn-ports-all@freebsd.org Wed Jan 2 20:01:23 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A0C7D142EAAD; Wed, 2 Jan 2019 20:01:23 +0000 (UTC) (envelope-from thomas.e.zander@googlemail.com) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1FBEB6DE84; Wed, 2 Jan 2019 20:01:22 +0000 (UTC) (envelope-from thomas.e.zander@googlemail.com) Received: by mail-wm1-f49.google.com with SMTP id d15so27583256wmb.3; Wed, 02 Jan 2019 12:01:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=byrW24TdKwe+q0zHuaHAkvtgp9un4fIt2KXma1GXC4o=; b=aHWLVw5+gSMcnwTZytOaEaexX+EJFKU/7C2kRQacSMBd8d7ow7WeNrXE5mtmqftJB2 NQBgcYQxHzOpkKGvP1ovomfFiKh6L6zQQjkbJYPBzZPlIiyTB8BN1qRWyTSU4f8mcvZQ n6ySClV7LxRwdoVLxAR8cJq+G1Mzv4WKAKJzjMf216+cjgItZdWRkt+DeB2k0sdPQfNZ 13qazyg7V4JExZ1b0u0QPKnIn8jrITt99mD7lQWWilvrrA4QNkCSK1Azd7/9FZ+rZlyP ONtUkptOocJdDOLehUHh+ZU2AGyAnXLmmxE/2vAWJEmkaEwqj17WJXeVAvtd1lhSvzdK 2l3g== X-Gm-Message-State: AA+aEWaoj9tM9BPdmSbH9VRFql/53lvjtDVY1pRO/pMR7w8P5ZSApU0m yvx6dpUZJ+UyxM3Z3NPrZ+TX8ZCcUIbORPqRxSnOEKaF X-Google-Smtp-Source: ALg8bN4HjsohGiUkjJTLE1O2F/LhhBkYQT/sTyh6dhYFXk/UET3qXNwcBd0YwY7Shk8Dx2TAjIXd+Pqgrmrdz+kE1Ag= X-Received: by 2002:a1c:d7d3:: with SMTP id o202mr38790427wmg.135.1546456073433; Wed, 02 Jan 2019 11:07:53 -0800 (PST) MIME-Version: 1.0 References: <201901021624.x02GOPKV082363@repo.freebsd.org> <1653712.CJpZife00y@mercury.ph.man.ac.uk> In-Reply-To: <1653712.CJpZife00y@mercury.ph.man.ac.uk> From: Thomas Zander Date: Wed, 2 Jan 2019 20:07:40 +0100 Message-ID: Subject: Re: svn commit: r489088 - head/audio/lastfm-desktop To: Max Brazhnikov Cc: "ports-committers@FreeBSD.org" , svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 1FBEB6DE84 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.95 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.95)[-0.949,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jan 2019 20:01:24 -0000 Hi Max, On Wed, 2 Jan 2019 at 19:39, Max Brazhnikov wrote: > > Log: > > Mark BROKEN. Port requires a qt4 build of vlc which was deprecated. > > Alternatively, you could have switched the port to phonon-gstreamer backend. In principle, > ports shouldn't force dependence on Phonon backends at all, any backend can be used. Un-breaking the port with the phonon-gstreamer backend should still be possible. As first step, I wanted to workaround a dependency problem. > > Modified: head/audio/lastfm-desktop/Makefile > > ============================================================================== > > --- head/audio/lastfm-desktop/Makefile Wed Jan 2 16:00:00 2019 (r489087) > > +++ head/audio/lastfm-desktop/Makefile Wed Jan 2 16:24:25 2019 (r489088) > > @@ -12,6 +12,7 @@ COMMENT= Official Last.fm desktop application suite > > LICENSE= GPLv3+ > > LICENSE_FILE= ${WRKSRC}/COPYING > > > > +BROKEN= Requires vlc-qt4 which was deprecated on 2018-12-31 > > DEPRECATED= Qt4 has been EOL since december 2015 > > EXPIRATION_DATE= 2019-03-15 > > > > @@ -43,7 +44,8 @@ GSTREAMER_DESC= Multimedia via Phonon-GStreamer > > GSTREAMER_USES= qt:4 > > GSTREAMER_USE= QT=phonon-gst_run > > VLC_DESC= Multimedia via Phonon-VLC > > -VLC_RUN_DEPENDS= phonon-vlc-qt4>=0.6.1:multimedia/phonon-vlc@qt4 > > +#multimedia/phonon-vlc@qt4 flavor was removed due to depreciation of vlc-qt4 > > +#VLC_RUN_DEPENDS= phonon-vlc-qt4>=0.6.1:multimedia/phonon-vlc@qt4 > > Any reason to keep this? Only for temporary documentation purposes. As you said, given interest, the VLC option can be completely removed. If you have time, feel free to beat me to it. Otherwise I'll look at it as soon as my machine is no longer busy with the vlc3->vlc migration test builds. Riggs