From owner-freebsd-bugs Wed Apr 2 21:52:39 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id VAA28214 for bugs-outgoing; Wed, 2 Apr 1997 21:52:39 -0800 (PST) Received: from sax.sax.de (sax.sax.de [193.175.26.33]) by freefall.freebsd.org (8.8.5/8.8.5) with SMTP id VAA28198 for ; Wed, 2 Apr 1997 21:52:27 -0800 (PST) Received: (from uucp@localhost) by sax.sax.de (8.6.12/8.6.12-s1) with UUCP id HAA17597; Thu, 3 Apr 1997 07:52:15 +0200 Received: (from j@localhost) by uriah.heep.sax.de (8.8.5/8.8.5) id HAA27737; Thu, 3 Apr 1997 07:51:44 +0200 (MET DST) Message-ID: <19970403075144.ZT46473@uriah.heep.sax.de> Date: Thu, 3 Apr 1997 07:51:44 +0200 From: j@uriah.heep.sax.de (J Wunsch) To: roberto@keltia.freenix.fr (Ollivier Robert) Cc: freebsd-bugs@freefall.freebsd.org Subject: Re: gnu/3176: `patch' creates files in wrong places (following Index) References: <199704022200.OAA27937@freefall.freebsd.org> <19970403015947.46958@keltia.freenix.fr> X-Mailer: Mutt 0.60_p2-3,5,8-9 Mime-Version: 1.0 X-Phone: +49-351-2012 669 X-PGP-Fingerprint: DC 47 E6 E4 FF A6 E9 8F 93 21 E0 7D F9 12 D6 4E Reply-To: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch) In-Reply-To: <19970403015947.46958@keltia.freenix.fr>; from Ollivier Robert on Apr 3, 1997 01:59:47 +0200 Sender: owner-bugs@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk As Ollivier Robert wrote: > Why does our patch(1) apply the -p1 only for *new* files ? There is an > inconsistency in that. It doesn't apply -p1 only to new files. > BTW cvs doesn't use context or unified diffs for its operations so it will > not see that problem. Nope. It's very common to send the output of cvs diff -u somewhere else for patching. It's used this way when moving diffs that are about to be committed to freefall, to avoid clobbering changes that have been done in the repository by other people. > Remember that neither Larry's version nor the GNU one has this problem to > my knowledge (or many people playing with many packages such as Perl5 would > have discovered before). This would surprise me mucho. If you can show an inconsistency between new and existing files, go ahead. As the PR stands, it only proved that Index: lines get precedence over other file names, and _this_ is a feature. -- cheers, J"org joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-)