From owner-p4-projects@FreeBSD.ORG  Thu Mar 10 11:14:58 2005
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id E574C16A4D0; Thu, 10 Mar 2005 11:14:57 +0000 (GMT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A21F416A4CE
	for <perforce@freebsd.org>; Thu, 10 Mar 2005 11:14:57 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8A88F43D41
	for <perforce@freebsd.org>; Thu, 10 Mar 2005 11:14:57 +0000 (GMT)
	(envelope-from davidxu@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j2ABEvWF031147
	for <perforce@freebsd.org>; Thu, 10 Mar 2005 11:14:57 GMT
	(envelope-from davidxu@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j2ABEv6V031144
	for perforce@freebsd.org; Thu, 10 Mar 2005 11:14:57 GMT
	(envelope-from davidxu@freebsd.org)
Date: Thu, 10 Mar 2005 11:14:57 GMT
Message-Id: <200503101114.j2ABEv6V031144@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	davidxu@freebsd.org using -f
From: David Xu <davidxu@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Subject: PERFORCE change 72829 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Mar 2005 11:14:58 -0000

http://perforce.freebsd.org/chv.cgi?CH=72829

Change 72829 by davidxu@davidxu_alona on 2005/03/10 11:14:32

	only call sched_fork_ksegrp with sched_lock held.

Affected files ...

.. //depot/projects/davidxu_thread/src/sys/kern/kern_thr.c#11 edit

Differences ...

==== //depot/projects/davidxu_thread/src/sys/kern/kern_thr.c#11 (text+ko) ====

@@ -163,14 +163,14 @@
 	td->td_proc->p_flag |= P_HADTHREADS;
 	newtd->td_sigmask = td->td_sigmask;
 	mtx_lock_spin(&sched_lock);
-	if (linkkg) {
+	if (linkkg)
 		ksegrp_link(newkg, p);
-		sched_fork_ksegrp(td, newkg);
-	}
 	thread_link(newtd, newkg);
 	PROC_UNLOCK(p);
 
 	/* let the scheduler know about these things. */
+	if (linkkg)
+		sched_fork_ksegrp(td, newkg);
 	sched_fork_thread(td, newtd);
 	TD_SET_CAN_RUN(newtd);
 	if ((uap->flags & THR_SUSPENDED) == 0)