Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 9 Dec 1995 06:33:07 +1100
From:      Bruce Evans <bde@zeta.org.au>
To:        current@FreeBSD.org, terry@lambert.org
Subject:   Re: POSIX compliance and time updates
Message-ID:  <199512081933.GAA09072@godzilla.zeta.org.au>

next in thread | raw e-mail | index | archive | help
>It seems pretty obvious that the ufs_setattr() code in the file
>/sys/ufs/ufs/ufs_vnops.c is bogusly requiring synchronous time
>updates in the non-async case.

>I believe that:

>		error = VOP_UPDATE(vp, &atimeval, &mtimeval, 1);

>should be:

>		error = VOP_UPDATE(vp, &atimeval, &mtimeval, 0);

I've been running with this change for years.  It is just an
optimization and is only wrong if the system crashes.  My comment about
it says that it is stupid to update times synchronously but not update
ids and permissions synchronously.

>This should significantly increase performance on the bogus create/delete
>benchmark.

The performance is still low.  100 creat/unlink's take

	5.01 real    0.01 user    0.14 sys

here.  They should take about 0.15 real (33 times faster).

Bruce



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199512081933.GAA09072>