From owner-freebsd-current Fri Dec 8 11:37:42 1995 Return-Path: owner-current Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id LAA12830 for current-outgoing; Fri, 8 Dec 1995 11:37:42 -0800 (PST) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id LAA12801 for ; Fri, 8 Dec 1995 11:37:33 -0800 (PST) Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id GAA09072; Sat, 9 Dec 1995 06:33:07 +1100 Date: Sat, 9 Dec 1995 06:33:07 +1100 From: Bruce Evans Message-Id: <199512081933.GAA09072@godzilla.zeta.org.au> To: current@FreeBSD.org, terry@lambert.org Subject: Re: POSIX compliance and time updates Sender: owner-current@FreeBSD.org Precedence: bulk >It seems pretty obvious that the ufs_setattr() code in the file >/sys/ufs/ufs/ufs_vnops.c is bogusly requiring synchronous time >updates in the non-async case. >I believe that: > error = VOP_UPDATE(vp, &atimeval, &mtimeval, 1); >should be: > error = VOP_UPDATE(vp, &atimeval, &mtimeval, 0); I've been running with this change for years. It is just an optimization and is only wrong if the system crashes. My comment about it says that it is stupid to update times synchronously but not update ids and permissions synchronously. >This should significantly increase performance on the bogus create/delete >benchmark. The performance is still low. 100 creat/unlink's take 5.01 real 0.01 user 0.14 sys here. They should take about 0.15 real (33 times faster). Bruce