From owner-freebsd-ports@FreeBSD.ORG  Wed Jan 26 01:43:38 2005
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3518616A4D0; Wed, 26 Jan 2005 01:43:36 +0000 (GMT)
Received: from obsecurity.dyndns.org
	(CPE0050040655c8-CM00111ae02aac.cpe.net.cable.rogers.com [69.199.47.57])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id C513243D46; Wed, 26 Jan 2005 01:43:35 +0000 (GMT)
	(envelope-from kris@obsecurity.org)
Received: by obsecurity.dyndns.org (Postfix, from userid 1000)
	id E689453327; Tue, 25 Jan 2005 17:43:33 -0800 (PST)
Date: Tue, 25 Jan 2005 17:43:33 -0800
From: Kris Kennaway <kris@obsecurity.org>
To: Michael Sierchio <kudzu@tenebras.com>
Message-ID: <20050126014333.GA76808@xor.obsecurity.org>
References: <41F6F431.6060005@tenebras.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="yrj/dFKFPuw6o+aM"
Content-Disposition: inline
In-Reply-To: <41F6F431.6060005@tenebras.com>
User-Agent: Mutt/1.4.2.1i
cc: ports@FreeBSD.org
cc: lioux@FreeBSD.org
Subject: Re: FreeBSD Port: qmail-1.03_3
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Jan 2005 01:43:38 -0000


--yrj/dFKFPuw6o+aM
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 25, 2005 at 05:36:49PM -0800, Michael Sierchio wrote:
>=20
> You have added a patch which is totally unneccesary, and I
> suggest that it be removed:
>=20
> in your patch-qmail-local....
>=20
> -     while ((k > i) && (cmds.s[k - 1] =3D=3D ' ') || (cmds.s[k - 1] =3D=
=3D '\t'))
> +     while ((k > i) && ((cmds.s[k - 1] =3D=3D ' ') || (cmds.s[k - 1] =3D=
=3D '\t')))
>=20
> This is totally bogus, the original code is correct.  Please do not
> make changes to contributed code simply because it makes it easier
> for you to understand.  There is no semantic difference between the
> two, ERGO the patch should not exist.  Please remove it.
>=20
> Shall I file a PR?

You could try sending a more politely worded email next time.

Kris

--yrj/dFKFPuw6o+aM
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (FreeBSD)

iD8DBQFB9vXFWry0BWjoQKURAj4gAJ9LEt7Z+X/wiMQF326OBWtzp9BvOgCeNSmB
LA3q7hIUK6b76lVgqDhJC+M=
=T7hM
-----END PGP SIGNATURE-----

--yrj/dFKFPuw6o+aM--