From nobody Sat Oct 25 20:28:05 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cvBDN4MWNz6DSf4 for ; Sat, 25 Oct 2025 20:28:20 +0000 (UTC) (envelope-from rlibby@gmail.com) Received: from mail-yx1-f45.google.com (mail-yx1-f45.google.com [74.125.224.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cvBDL0lC3z3ZDS for ; Sat, 25 Oct 2025 20:28:18 +0000 (UTC) (envelope-from rlibby@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of rlibby@gmail.com designates 74.125.224.45 as permitted sender) smtp.mailfrom=rlibby@gmail.com Received: by mail-yx1-f45.google.com with SMTP id 956f58d0204a3-63b710f276fso3277260d50.1 for ; Sat, 25 Oct 2025 13:28:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761424097; x=1762028897; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7xmCQfITdSRooTSdhPD6juZeD60m4HtCllE3eY7sN3E=; b=Kw+1i4NBsdV8nGLfb7QJJAH9r5Aq+mgkouDcO5xHvdw5t7+zgfZl6A6zYJUVYnl8DD HLW+gSmWejChrgFcP3w82As9NwX+fIJbHmZu124PAhKL2ZPyke0VMZAANPHRFAjU5g9T gWyp6gr8p0Q6JCRMGQWLSCgiF4KJ8Xw5F+bEuhB/MGaTxWQZNAeu1Thh1M5quOCRVD5N iY6T6BDui8fbI8jZpX5QNkT/dVjIyftwNUrHojFXI6AFQJsk9GN3AXzDWKYz/Gv65CJR wAl9oT76OjdETo3+Ytabzyz61ce0QtDy8QkRA2r+/TNUjuPI/FEuGIIVWFVSYpbRvBj3 NUTw== X-Forwarded-Encrypted: i=1; AJvYcCXwruXXj1JWNLH9uG4qoY2WUerCnSnrPvlhlEqty+gdtbQspRe3JLEmOeg6u9YGRJWk3ys/vulAcm2MfuxQJ78ClqQi@freebsd.org X-Gm-Message-State: AOJu0YzmTg6NaVlqxoDCrTnohlhocp6hpJKr9U1KpGSWMplrtPwosJog kIEGKffA5kDBTap1Gj1qv+EnY69ZCo6bCNxDkG0poBb3cdCKQnbnHlZuzAk72g== X-Gm-Gg: ASbGncvWi4pJBdshhXe93BaNYwO1LBI8BXfBE3Dc8B86ce1VXp8dPlJ66+alXZDy8MA V9s7hfltl9/UgwSU9dgG/XeiSi6mnIrbVHXyPVJyXYJmNRxMtW4TQg9WiYON2boINKKYQZxV8Cu s36DiJuIwSfdzYWASAvD+H+D4LPB4aS7udmbvP7vgF3LoWqBHcy4fdG4GUZPJv+zKg4XMG5FNoT DoY2CfI2MpElPvd5yE3TwUMWlEJJ2qtkPRFMgdNLUOjGu+6VCa0YvZ22QXr/Gbwun3dqpJqBMsy ym1iYqXgVYpLGZWz8o4h5bMCMxmjpdE13S0Avswb1KIYsyjjIQ8MdmSlxlPsG3t2Y2YLBiSAdtL 3l+pzMTIb+MHODCOaKYYlYE8sE+cWd1w2hb6IXyD302Tv4DlguvIZF5JrE+Yr0z8UlZGT50DJkG /9cQyJJ54zsPp1yEvkd86ilCihQaOFbdC3f87p3upSVTpguXVOwg== X-Google-Smtp-Source: AGHT+IGk8hGNkl6BiQuN7VkyToQFdZncBdL6Gq4rPLXbZDur7pvfTuhQHEVu/MqCbc5r4MA338JvrA== X-Received: by 2002:a53:c805:0:b0:63e:12d7:8f35 with SMTP id 956f58d0204a3-63e161f4d20mr20099796d50.49.1761424097144; Sat, 25 Oct 2025 13:28:17 -0700 (PDT) Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com. [209.85.128.175]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-63f4c455454sm851377d50.24.2025.10.25.13.28.16 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Oct 2025 13:28:16 -0700 (PDT) Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-783fa3aa582so37834627b3.3 for ; Sat, 25 Oct 2025 13:28:16 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCXoazxdyUCSZR8Gss8IeBVp3mK/gePLArEZrq2SkjBQueh0OmD/0c2ld604kd9EMssi9Dups2rRUn8KtzTvzGLHbupb@freebsd.org X-Received: by 2002:a05:690c:385:b0:785:4803:5e2b with SMTP id 00721157ae682-785480363fcmr159586017b3.20.1761424096185; Sat, 25 Oct 2025 13:28:16 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <202510201832.59KIWCG0006624@gitrepo.freebsd.org> In-Reply-To: <202510201832.59KIWCG0006624@gitrepo.freebsd.org> From: Ryan Libby Date: Sat, 25 Oct 2025 13:28:05 -0700 X-Gmail-Original-Message-ID: X-Gm-Features: AS18NWC_bNRGAAreIS_VhM_9PnPJamxfoMxBYzoI-mimPHVTTUSJ-qgi21BfEGg Message-ID: Subject: Re: git: e1aeb58cbbc3 - main - inet_net_test: Use int to hold expected return values from inet_net_pton To: John Baldwin Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / X-Spamd-Result: default: False [0.51 / 15.00]; RBL_VIRUSFREE_BOTNET(2.00)[74.125.224.45:from]; NEURAL_HAM_SHORT(-1.00)[-0.999]; NEURAL_HAM_MEDIUM(-0.80)[-0.798]; FORGED_SENDER(0.30)[rlibby@freebsd.org,rlibby@gmail.com]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), No valid DKIM,none]; BAD_REP_POLICIES(0.10)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-0.10)[-0.095]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; RCVD_TLS_LAST(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MISSING_XM_UA(0.00)[]; FREEFALL_USER(0.00)[rlibby]; ASN(0.00)[asn:15169, ipnet:74.125.0.0/16, country:US]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-all@freebsd.org]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_NEQ_ENVFROM(0.00)[rlibby@freebsd.org,rlibby@gmail.com]; FREEMAIL_ENVFROM(0.00)[gmail.com]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org]; RWL_MAILSPIKE_POSSIBLE(0.00)[74.125.224.45:from]; R_DKIM_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(0.00)[+ip4:74.125.0.0/16]; RCVD_IN_DNSWL_NONE(0.00)[74.125.224.45:from,209.85.128.175:received] X-Rspamd-Queue-Id: 4cvBDL0lC3z3ZDS On Mon, Oct 20, 2025 at 11:32=E2=80=AFAM John Baldwin wro= te: > > The branch main has been updated by jhb: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3De1aeb58cbbc3839db93ec38ce4= 91b7b9383d5649 > > commit e1aeb58cbbc3839db93ec38ce491b7b9383d5649 > Author: John Baldwin > AuthorDate: 2025-10-20 18:31:41 +0000 > Commit: John Baldwin > CommitDate: 2025-10-20 18:31:41 +0000 > > inet_net_test: Use int to hold expected return values from inet_net_p= ton > > GCC warns about the sign mismatch in comparisons: > > lib/libc/tests/net/inet_net_test.cc: In member function 'virtual void= {anonymous}::atfu_tc_inet_net_inet4::body() const': > lib/libc/tests/net/inet_net_test.cc:86:17: error: comparison of integ= er expressions of different signedness: 'int' and 'const unsigned int' [-We= rror=3Dsign-compare] > 86 | ATF_REQUIRE_EQ(bits, addr.bits); > | ^~~~~~~~~~~~~~ > lib/libc/tests/net/inet_net_test.cc: In member function 'virtual void= {anonymous}::atfu_tc_inet_net_inet6::body() const': > lib/libc/tests/net/inet_net_test.cc:205:17: error: comparison of inte= ger expressions of different signedness: 'int' and 'const unsigned int' [-W= error=3Dsign-compare] > 205 | ATF_REQUIRE_EQ(bits, addr.bits); > | ^~~~~~~~~~~~~~ > > Fixes: 8f4a0d2f7b96 ("libc: Import OpenBSD's inet_net_{ntop,= pton}") > --- > lib/libc/tests/net/inet_net_test.cc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/libc/tests/net/inet_net_test.cc b/lib/libc/tests/net/ine= t_net_test.cc > index 4ecf5a3de492..c4411373165e 100644 > --- a/lib/libc/tests/net/inet_net_test.cc > +++ b/lib/libc/tests/net/inet_net_test.cc > @@ -50,7 +50,7 @@ ATF_TEST_CASE_BODY(inet_net_inet4) > > struct test_addr { > std::string input; > - unsigned bits; > + int bits; > std::string output; > }; > > @@ -134,7 +134,7 @@ ATF_TEST_CASE_BODY(inet_net_inet6) > > struct test_addr { > std::string input; > - unsigned bits; > + int bits; > std::string output; > }; > > Could you MFC e1aeb58cbbc3 and aa358ce3ca8e to stable/15 to fix the gcc build there, or would you mind if I did? Thanks, Ryan