Date: Fri, 20 Jul 2012 23:35:10 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Jeremy Messenger <mezz.freebsd@gmail.com> Cc: gnome@freebsd.org, ruby@freebsd.org, johans@freebsd.org, Edwin Groothuis <edwin@mavetju.org>, freebsd-ports@freebsd.org Subject: Re: How to remove erroneous deps from pkgng Message-ID: <500A4D9E.3050701@FreeBSD.org> In-Reply-To: <CADLFttf7t8cPpXiN6b6pCv5Waxa-eVQh3Ye=i0Dydgenb7etug@mail.gmail.com> References: <D0056D18EAAD41119F26D0715FA52FB6@Rivendell> <50098EEF.8040801@shatow.net> <1E76612CE817410FAA2CF925F9CC300A@Rivendell> <CA%2B7WWSf%2B=rxt1gFfDXS%2BCwggJ2wSLSvdyzCR=GW2TZmPT0-VHw@mail.gmail.com> <AD251933EC034F5BA4FF2F37757C8D4D@Rivendell> <5009A876.2010905@freebsd.org> <CA%2B7WWSfXcBQjoWBYP63oZh6_-x5_FJtLdsk-iPepekS1TeRWJg@mail.gmail.com> <5009AE6A.1040109@freebsd.org> <CAL409KxL6PK8rzd6ksoe22xg-c0s3wMXXn4PwfWjKAPhYE_yUg@mail.gmail.com> <5009B199.8030102@freebsd.org> <CAL409KwoE=Ko%2B-0iRt%2BENPG-Ry4DghGqb%2Bah9WQBejtba61QFA@mail.gmail.com> <CA%2B7WWSdRAhWmy=sw2Bci8fZRuDLrM8Pn0HXN1ocwbnpM9c13Bg@mail.gmail.com> <CA%2B7WWSf6mLq1Xfj8iK4-9sOUFn4ohtS4jG37muNPzGXke9%2BAjw@mail.gmail.com> <5009DB2F.5070605@FreeBSD.org> <5009EE56.2060006@FreeBSD.org> <CADLFttf7t8cPpXiN6b6pCv5Waxa-eVQh3Ye=i0Dydgenb7etug@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 07/20/2012 22:02, Jeremy Messenger wrote: > I prefer to leave it alone and port a feature that I have added in the > bsd.mate.mk (repocopied from bsd.gnome.mk) that support 'USE_GNOME= > foo:build bar:run foobar'. The 'foobar' without the :* means that it's > both build/run time dependency. It's available at: > > http://www.marcuscom.com:8080/cgi-bin/cvsweb.cgi/ports-experimental/Mk/bsd.mate.mk That sounds like a good fix, although it doesn't look like pkg-config was pulled over. If you decide to do it this way there should probably be a test for things that cannot be one type of dependency or the other so that someone who used pkgconfig:run would get a helpful error message. And of course for things that don't have a : they should get appropriate defaults. By my count there are over 10k ports using just pkgconfig, it's probably a larger number that use other gnome bits. Baptiste already volunteered to do an exp-run for this topic on Monday. If you don't have time to get your changes ready before then IMO we should go ahead with removing the line from bsd.gnome.mk. Making that correct fix now won't negatively affect your ability to make a different/better change later; but doing it now will give us more opportunity to see the results and fix any regressions. If you decide to go forward, please file a PR with your change, and coordinate with Baptiste. Thanks! Doug -- Change is hard.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?500A4D9E.3050701>