Date: Sat, 21 Sep 2019 20:58:07 +0200 From: Piotr Kubaj <pkubaj@anongoth.pl> To: Mark Linimon <linimon@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r512530 - head/audio/grip Message-ID: <20190921185807.GF2354@KGPE-D16> In-Reply-To: <201909211818.x8LIIXLm054927@repo.freebsd.org> References: <201909211818.x8LIIXLm054927@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--svExV93C05KqedWb
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Disposition: inline
Since we force new GCC anyway on GCC platforms with USES=compiler:c++11-lang, why do a separate check for base GCC in
+.if ${CHOSEN_COMPILER_TYPE} == gcc && ${COMPILER_VERSION} <= 42?
On 19-09-21 18:18:33, Mark Linimon wrote:
>Author: linimon
>Date: Sat Sep 21 18:18:33 2019
>New Revision: 512530
>URL: https://svnweb.freebsd.org/changeset/ports/512530
>
>Log:
> Fix build on GCC-based systems:
>
> /usr/local/lib/libgraphite2.so.3: undefined reference to `__cxa_throw_bad_array_new_length@CXXABI_1.3.8'
>
> Approved by: portmgr (tier-2 blanket)
>
>Modified:
> head/audio/grip/Makefile
>
>Modified: head/audio/grip/Makefile
>==============================================================================
>--- head/audio/grip/Makefile Sat Sep 21 18:14:05 2019 (r512529)
>+++ head/audio/grip/Makefile Sat Sep 21 18:18:33 2019 (r512530)
>@@ -18,7 +18,8 @@ LIB_DEPENDS= libcurl.so:ftp/curl \
> libid3.so:audio/id3lib \
> libpopt.so:devel/popt
>
>-USES= gmake libtool localbase pathfix pkgconfig
>+USES= compiler:c++11-lang gmake gnome libtool localbase \
>+ pathfix pkgconfig xorg
> USE_XORG= ice sm x11 xext
> USE_GNOME= cairo gdkpixbuf2 gnomeprefix libgnomeui vte
>
>@@ -50,6 +51,8 @@ DEFAULT_CDROM_DEVICE=${WITH_CDROM_DEVICE}
> DEFAULT_CDROM_DEVICE=/dev/cd0
> .endif
>
>+.include <bsd.port.pre.mk>
>+
> pre-everything::
> .if !defined(WITH_CDROM_DEVICE)
> @${ECHO_MSG} "===> The default CDROM device is ${DEFAULT_CDROM_DEVICE}"
>@@ -60,5 +63,8 @@ pre-everything::
> post-patch:
> @${REINPLACE_CMD} -e 's|/dev/cdrom|${DEFAULT_CDROM_DEVICE}|' \
> ${WRKSRC}/src/grip.c
>+.if ${CHOSEN_COMPILER_TYPE} == gcc && ${COMPILER_VERSION} <= 42
>+ ${REINPLACE_CMD} -e '/pragma/d' ${WRKSRC}/src/cdpar.c
>+.endif
>
>-.include <bsd.port.mk>
>+.include <bsd.port.post.mk>
--svExV93C05KqedWb
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQJkBAABCgBOFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAl2Gcr8wFIAAAAAAFQAS
cGthLWFkZHJlc3NAZ251cGcub3JncGt1YmFqQGFub25nb3RoLnBsAAoJEHpZm4Ug
g5yd3BMP/RgziX4TaB4bA6OnSbMd7eJ4ML8hxRsgWy1wbDc/sQYdXUeIEYybl6on
OxDfrxoz7I2BFSu0SGgEC7K02F9j0jEWxoiUdtagEwPOdPjhbtYhR4Fc5ECxFpoS
JDwGcnybYSL5GQaq+Yo33Hfr8we8dg5jye/4WemLMEa6Dbfz06QU8SdSk1k5Xuxr
RiG50hxCsBXAxDn6yvzNwekT9jtc+XimVXMx7Ywy2o3OpWP8RtyfPtj0eeBjhrYm
Ml2lgDFURU0xyXwLY0n6obUWuDSBebRH5H5yY5b4nggRl3JlHDDgOrMcia3hSejv
4XVIuiNgq1o8G7r+jkJTcnHyo2HDugNNaB5M0+UTgSVJZTtd/aPWU308qR25viNK
WQJLN1X+Pt/GE/xXb5ny/J7EyI/Ad7A55YdRxq0d0cTI9SzNym+2YNp/y664dM14
Rg89WKnPInhvC8WXZnDkytkFQLyaIriO13jyelUh8X2DCn64TqhIlgwDF9l/1rkx
qOagtJALpifey33pGQNhvkTyhZ4eu+1HoDhg8jGlwOt/LefcQLB3Cf7yKsMy1liH
ahGcLoRYq3guZuqjRTOi9jUi0CusyVU6VQhqxGOSgkzbLd9ceRbMmm90Xb84fMnV
5V391U7uVE/bVDVv+9xNJivLUoZClxsUxBq6R3/JLI9+n9zj1wMQ
=Svhl
-----END PGP SIGNATURE-----
--svExV93C05KqedWb--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190921185807.GF2354>