From owner-svn-src-head@freebsd.org Mon Feb 27 01:51:50 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 44142CEF63E; Mon, 27 Feb 2017 01:51:50 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id EF10B8A7; Mon, 27 Feb 2017 01:51:49 +0000 (UTC) (envelope-from cy.schubert@komquats.com) Received: from spqr.komquats.com ([96.50.22.10]) by shaw.ca with SMTP id iATVcPaJgC3JIiATWcuvoU; Sun, 26 Feb 2017 18:51:43 -0700 X-Authority-Analysis: v=2.2 cv=XbT59Mx5 c=1 sm=1 tr=0 a=jvE2nwUzI0ECrNeyr98KWA==:117 a=jvE2nwUzI0ECrNeyr98KWA==:17 a=kj9zAlcOel0A:10 a=n2v9WMKugxEA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=km5jbiIkLU5slP2OBFIA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 495161AB; Sun, 26 Feb 2017 17:51:41 -0800 (PST) Received: from slippy (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id v1R1pe1F003587; Sun, 26 Feb 2017 17:51:40 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201702270151.v1R1pe1F003587@slippy.cwsent.com> X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.6 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: "Pedro F. Giffuni" cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r314322 - head/lib/librss In-Reply-To: Message from "Pedro F. Giffuni" of "Mon, 27 Feb 2017 00:10:01 +0000." <201702270010.v1R0A1wm074123@repo.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Sun, 26 Feb 2017 17:51:40 -0800 X-CMAE-Envelope: MS4wfGyCCHM2hDRDRaTyfbR5cPLfUsVbUudgX1nN9KSnFLOlEjvC7GjtSbN5I0uNWwIv4nEt8J+lzpO46RZ/kEj6XXYiRXD+gUdFl7UMBElLI/02jvbpVjm/ DYUMTr8cBjvzfQVs2uSXR/8DsVkwutIfIzSBJaYkv+bnlrVMWFhXcZBc1sT74dzB0xBGHAU587R3+DYjzvt6SNFBeHHAAy7GHDw3gWu99rNNlRU4fsxtOX5e as9fn9p7zQZGbPniounvc5ia7JmwPzgjeZnTOkJPUDd4lizpHfl1fuhIRs61nvh2 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Feb 2017 01:51:50 -0000 In message <201702270010.v1R0A1wm074123@repo.freebsd.org>, "Pedro F. Giffuni" w rites: > Author: pfg > Date: Mon Feb 27 00:10:00 2017 > New Revision: 314322 > URL: https://svnweb.freebsd.org/changeset/base/314322 > > Log: > librss: simplify some NULL checks. > > MFC after: 1 week > > Modified: > head/lib/librss/librss.c > > Modified: head/lib/librss/librss.c > ============================================================================= > = > --- head/lib/librss/librss.c Sun Feb 26 22:17:06 2017 (r314321) > +++ head/lib/librss/librss.c Mon Feb 27 00:10:00 2017 (r314322) > @@ -244,10 +244,10 @@ rss_config_get(void) > return (rc); > > error: > - if ((rc != NULL) && rc->rss_bucket_map) > + if (rc != NULL) { > free(rc->rss_bucket_map); What happens if rc is not NULL and rc->rss_bucket_map is NULL? > - if (rc != NULL) > free(rc); > + } > return (NULL); > } > > > -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.