From owner-svn-ports-all@freebsd.org  Sun Aug 16 10:08:25 2015
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id AB1789BA6EC;
 Sun, 16 Aug 2015 10:08:25 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 9E5121FE7;
 Sun, 16 Aug 2015 10:08:25 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 9D41719D5; Sun, 16 Aug 2015 10:08:25 +0000 (UTC)
Date: Sun, 16 Aug 2015 10:08:25 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Romain Tarti?re <romain@blogreen.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r394390 - in head/lang/mono: . files
Message-ID: <20150816100825.GA77913@FreeBSD.org>
References: <201508160654.t7G6slkR012462@repo.freebsd.org>
 <20150816080547.GA27946@FreeBSD.org>
 <20150816091404.GA8322@blogreen.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150816091404.GA8322@blogreen.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 16 Aug 2015 10:08:25 -0000

On Sun, Aug 16, 2015 at 11:14:04AM +0200, Romain Tarti?re wrote:
> On Sun, Aug 16, 2015 at 08:05:47AM +0000, Alexey Dokuchaev wrote:
> > >  PORTNAME=	mono
> > > -PORTVERSION=	4.0.1.28
> > > +PORTVERSION=	4.0.3.20
> > >  CATEGORIES=	lang
> > > [...]
> > > -WRKSRC=	${WRKDIR}/mono-4.0.1
> > > +WRKSRC=	${WRKDIR}/mono-4.0.3
> > 
> > You could've used ${PORTVERSION:R} instead of literal 4.0.3, it would allow
> > you not to touch this line on subsequent updates.
> 
> The problem is that upstream is quite inconsistent and started to use 3
> or 4 groups of number as the version number for the archive while the
> directory name only has 3 groups of digits.
> 
> [...]
> 
> I'm not sure about a future '4.0.4' without the fourth part which needs
> no adjustment.  Any generic solution here would be really cute!

I see.  Personally I'd try to avoid hardcoding numbers: ${PORTVERSION:R}
would work for the next minor update; if the next update turns out to be
major (three-digit), it should be changed to ${PORTVERSION}.  At least in
this case, there is a chance that you won't have to adjust WRKSRC.  When
using hardcoded numbers, you 100% would have to change that line on every
update, be it minor or major (better put, 3- or 4-digit).

./danfe