From owner-svn-src-all@freebsd.org Mon Jan 11 08:36:59 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DE81FA6C0E0; Mon, 11 Jan 2016 08:36:59 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from forward14j.cmail.yandex.net (forward14j.cmail.yandex.net [IPv6:2a02:6b8:0:1630::b4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "forwards.mail.yandex.net", Issuer "Yandex CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 97E0F1BA3; Mon, 11 Jan 2016 08:36:59 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from smtp13.mail.yandex.net (smtp13.mail.yandex.net [95.108.130.68]) by forward14j.cmail.yandex.net (Yandex) with ESMTP id 4AF692109E; Mon, 11 Jan 2016 11:36:46 +0300 (MSK) Received: from smtp13.mail.yandex.net (localhost [127.0.0.1]) by smtp13.mail.yandex.net (Yandex) with ESMTP id 31B74E404E5; Mon, 11 Jan 2016 11:36:45 +0300 (MSK) Received: by smtp13.mail.yandex.net (nwsmtp/Yandex) with ESMTPSA id vaWl9ZuTsg-aic4iQCK; Mon, 11 Jan 2016 11:36:44 +0300 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client certificate not present) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1452501404; bh=7ibKSs3KzkgPXg+rQ4FoZcPu33zvRQWXswhzelUuv3k=; h=Subject:To:References:From:X-Enigmail-Draft-Status:Message-ID: Date:User-Agent:MIME-Version:In-Reply-To:Content-Type: Content-Transfer-Encoding; b=UyzwBIuCvzj0etpBGKJu2gyDm4JPyWQbw+JF7+t31o5si0iPOi+Psu5/Pa6TfPzJp vShuLkUqwfHRPPju0N9Oqt4sEyPxr31qD7zW5rEw5kQ6xUCvej++pJ3JhatJBSEzpC 5mifN0rvhb6ZyeJ6zJ1UbnoH61OBLrS2ebDCgGX4= Authentication-Results: smtp13.mail.yandex.net; dkim=pass header.i=@yandex.ru X-Yandex-ForeignMX: US Subject: Re: svn commit: r292788 - in head/sys: geom/part sys To: Ravi Pokala , Allan Jude , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201512271812.tBRICD3A044563@repo.freebsd.org> <1F9E33A5-A9D7-44A9-9519-2A1593BFF990@panasas.com> From: "Andrey V. Elsukov" X-Enigmail-Draft-Status: N1110 Message-ID: <56936975.9000202@yandex.ru> Date: Mon, 11 Jan 2016 11:36:05 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1F9E33A5-A9D7-44A9-9519-2A1593BFF990@panasas.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jan 2016 08:37:00 -0000 On 11.01.16 07:54, Ravi Pokala wrote: > In that review, there was discussion about the sorting of aliases in (enum g_part_alias). It was originally thought that the aliases needed to be sorted, due to binary searching in g_part_alias_name(). It turned out that g_part_alias_name() did a linear search, so the list didn't strictly need to be sorted. But, there was talk of potentially switching to a binary search later, so Allan went with the sorted version. Hi, no, my note was relate to the following possible problem: you have some stable/10 and some geom_part_panasas module installed from the ports in the /boot/modules. When you rebuild the kernel after merging r292788 your module will use old values of g_part_alias and thus it will get not the same aliases. You will need rebuild your module to fix this. -- WBR, Andrey V. Elsukov